Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behavior of estimateTableSize #845

Closed
wants to merge 3 commits into from
Closed

Conversation

birdstorm
Copy link
Contributor

@birdstorm birdstorm commented Jun 20, 2019

Close #844
When estimated count is 0, it is possible that statistics information is not read correctly. Just set its estimate count to Long.Max since we do not want to broadcast this table.

Copy link
Collaborator

@marsishandsome marsishandsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add more PR description

@birdstorm
Copy link
Contributor Author

/run-all-tests

@birdstorm
Copy link
Contributor Author

already merged.

@birdstorm birdstorm closed this Jun 21, 2019
@birdstorm birdstorm deleted the fix-table-size-estimation branch June 21, 2019 07:05
birdstorm added a commit that referenced this pull request Jun 26, 2019
zhexuany pushed a commit to zhexuany/tispark that referenced this pull request Oct 15, 2019
wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tables might be incorrectly broadcasted if statistics fail to calculate table size
2 participants