Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiup fails to reload when there is only one TiKV and one PD #661

Closed
BusyJay opened this issue Aug 6, 2020 · 0 comments · Fixed by #662
Closed

tiup fails to reload when there is only one TiKV and one PD #661

BusyJay opened this issue Aug 6, 2020 · 0 comments · Fixed by #662
Assignees
Labels
type/bug Categorizes issue as related to a bug.

Comments

@BusyJay
Copy link
Contributor

BusyJay commented Aug 6, 2020

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?
    Deploy a cluster that has only one TiKV and one PD. And then restart the cluster.
% tiup cluster reload test-cluster
Restarting component pd
        Stopping instance 172.0.0.1
        Stop pd 172.0.0.1:2349 success
        Starting instance pd 172.0.0.1:2349
        Start pd 172.0.0.1:2349 success
Restarting component tikv
Still waitting for the PD leader to be elected
Evicting 1 leaders from store 172.0.0.1:20160...
Still waitting for 1 store leaders to transfer...
Still waitting for 1 store leaders to transfer...
  1. What did you expect to see?
    Reload success quickly.

  2. What did you see instead?
    tiup keeps waiting for TiKV to evict all its leader. However, there is only one TiKV, so evict leader will never succeed. It will wait until timeout.

  3. What version of TiUP are you using (tiup --version)?

% tiup --version
v1.0.8 tiup
Go Version: go1.13
Git Branch: master
GitHash: 4276089

Note that the same deploy topology, reloading pd can finish instantly. tiup seems to skip evicting leader for PD already. It should do the same thing for TiKV.

@BusyJay BusyJay added the type/bug Categorizes issue as related to a bug. label Aug 6, 2020
@lucklove lucklove self-assigned this Aug 6, 2020
@lucklove lucklove added this to Issue Backlog: Need Triage in SIG TiUP Kanban via automation Aug 6, 2020
lucklove added a commit to lucklove/tiup that referenced this issue Aug 6, 2020
Fix pingcap#661

Signed-off-by: lucklove <gnu.crazier@gmail.com>
SIG TiUP Kanban automation moved this from Issue Backlog: Need Triage to Done Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Categorizes issue as related to a bug.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants