Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip evict store when only 1 tikv #662

Merged
merged 3 commits into from Aug 10, 2020
Merged

Conversation

lucklove
Copy link
Member

@lucklove lucklove commented Aug 6, 2020

Fix #661

Signed-off-by: lucklove gnu.crazier@gmail.com

Support skipping evicting store when there is only 1 tikv

Fix pingcap#661

Signed-off-by: lucklove <gnu.crazier@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2020

Codecov Report

Merging #662 into master will increase coverage by 0.62%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #662      +/-   ##
==========================================
+ Coverage   56.71%   57.34%   +0.62%     
==========================================
  Files         242      243       +1     
  Lines       17469    17516      +47     
==========================================
+ Hits         9908    10045     +137     
+ Misses       6265     6168      -97     
- Partials     1296     1303       +7     
Flag Coverage Δ
#coverage 57.34% <ø> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/github.com/pingcap/tiup/pkg/cluster/spec/spec.go 90.94% <0.00%> (-2.62%) ⬇️
...hub.com/pingcap/tiup/pkg/cluster/ansible/import.go 48.07% <0.00%> (-1.93%) ⬇️
...c/github.com/pingcap/tiup/pkg/cluster/spec/tikv.go 52.85% <0.00%> (-1.56%) ⬇️
...m/pingcap/tiup/components/cluster/command/check.go 81.63% <0.00%> (-0.50%) ⬇️
...src/github.com/pingcap/tiup/pkg/cluster/manager.go 70.37% <0.00%> (-0.20%) ⬇️
....com/pingcap/tiup/pkg/cluster/spec/spec_manager.go 67.50% <0.00%> (-0.15%) ⬇️
...c/github.com/pingcap/tiup/pkg/cluster/api/dmapi.go 61.31% <0.00%> (ø)
....com/pingcap/tiup/pkg/cluster/operation/destroy.go 54.48% <0.00%> (ø)
...com/pingcap/tiup/pkg/cluster/spec/server_config.go 65.87% <0.00%> (ø)
....com/pingcap/tiup/pkg/cluster/clusterutil/retry.go
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aca7d01...41ad240. Read the comment docs.

Copy link
Contributor

@july2993 july2993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also skip in PostRestart?
rest LGTM

Signed-off-by: lucklove <gnu.crazier@gmail.com>
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 7, 2020
@lucklove lucklove added this to In progress in SIG TiUP Kanban via automation Aug 10, 2020
@lucklove lucklove added this to the v1.1.0 milestone Aug 10, 2020
@lonng
Copy link
Contributor

lonng commented Aug 10, 2020

Do we need to skip the evict leader for PD?

@lucklove
Copy link
Member Author

Do we need to skip the evict leader for PD?

PD has already been skipped.

@lonng
Copy link
Contributor

lonng commented Aug 10, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 10, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 659

@lonng lonng merged commit 6acff16 into pingcap:master Aug 10, 2020
SIG TiUP Kanban automation moved this from In progress to Done Aug 10, 2020
@lonng lonng deleted the skip-evict branch August 10, 2020 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

tiup fails to reload when there is only one TiKV and one PD
5 participants