Move to Go 1.21

[dveeden]

What problem does this PR solve?

Close #2239

• Upgrade Go from 1.18/1.19 to 1.21
• Upgrade actions/setup-go from v2 to v4
• Upgrade revive from v1.2.4 to v1.3.2
• Upgrade golangci-lint from v1.50.0 to v1.54.1

What is changed and how it works?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Release notes:

NONE

[codecov-commenter]

Codecov Report

Patch coverage has no change and project coverage change: -0.33% ⚠️

Comparison is base (e450cb3) 56.13% compared to head (77a9717) 55.80%.

❗ Current head 77a9717 differs from pull request most recent head fb437cc. Consider uploading reports for the commit fb437cc to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2249      +/-   ##
==========================================
- Coverage   56.13%   55.80%   -0.33%     
==========================================
  Files         320      320              
  Lines       33866    33866              
==========================================
- Hits        19009    18896     -113     
- Misses      12587    12698     +111     
- Partials     2270     2272       +2     

Flag	Coverage Δ
cluster	44.55% <ø> (-0.46%)	⬇️
dm	25.69% <ø> (-0.04%)	⬇️
playground	15.73% <ø> (-0.02%)	⬇️
tiup	15.88% <ø> (ø)
unittest	22.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dveeden]

/cc @srstack

[dveeden]

Revive was giving these errors:

  ✘  https://revive.run/r#early-return  if c { ... } else { ... break } can be simplified to if !c { ... break } ...  
  ./pkg/cluster/executor/scp.go:131:12

  ✘  https://revive.run/r#early-return  if c { ... } else { ... break } can be simplified to if !c { ... break } ... (move short variable declaration to its own line if necessary)  
  ./components/dm/command/root.go:200:3

  ✘  https://revive.run/r#early-return  if c { ... } else { ... break } can be simplified to if !c { ... break } ... (move short variable declaration to its own line if necessary)  
  ./components/cluster/command/root.go:243:3

I've removed the early-return check now in the config as I'm not sure if changing the code is the right solution.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kaaaaaaang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2023-08-16 07:48:01.480351078 +0000 UTC m=+703646.029367064: ☑️ agreed by kaaaaaaang.