Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for rocky linux #2333

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Add check for rocky linux #2333

merged 1 commit into from
Dec 18, 2023

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Dec 18, 2023

What problem does this PR solve?

Rocky Linux 9.1 and later is listed in the documentation as supported, but the checks don't agree with this.

What is changed and how it works?

Add rocky linux to the check

See also:

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 18, 2023
@dveeden
Copy link
Contributor Author

dveeden commented Dec 18, 2023

Note that there is one open issue related to Rocky Linux: #2292
However I don't think that changes the support status.

/cc @jebter

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (c53895c) 55.53% compared to head (6698f56) 55.42%.

❗ Current head 6698f56 differs from pull request most recent head c89a345. Consider uploading reports for the commit c89a345 to get more accurate results

Files Patch % Lines
pkg/cluster/operation/check.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2333      +/-   ##
==========================================
- Coverage   55.53%   55.42%   -0.11%     
==========================================
  Files         325      325              
  Lines       34757    34764       +7     
==========================================
- Hits        19300    19265      -35     
- Misses      13144    13187      +43     
+ Partials     2313     2312       -1     
Flag Coverage Δ
cluster 44.78% <0.00%> (-0.12%) ⬇️
dm 25.44% <0.00%> (-0.05%) ⬇️
playground 15.24% <ø> (-0.02%) ⬇️
tiup 33.48% <ø> (ø)
unittest 22.29% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dveeden
Copy link
Contributor Author

dveeden commented Dec 18, 2023

@kaaaaaaang kaaaaaaang added this to the v1.14.1 milestone Dec 18, 2023
@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 18, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-18 08:34:20.550116276 +0000 UTC m=+863551.587343191: ☑️ agreed by kaaaaaaang.

@kaaaaaaang
Copy link
Collaborator

/merge

@kaaaaaaang
Copy link
Collaborator

/approve

Copy link
Contributor

ti-chi-bot bot commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 18, 2023
@ti-chi-bot ti-chi-bot bot merged commit ced2d6d into pingcap:master Dec 18, 2023
19 checks passed
kaaaaaaang pushed a commit that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants