Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: auto tiproxy sign certs #2372

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Jan 29, 2024

What problem does this PR solve?

User needs to manually set session-xxxxx for tidb, to make tiproxy migration works. However, we could just generate a self-signed cert automatically. There is no security implication: the only requirement for this cert, is that, it should be same on all tidb instances.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
[2024/01/29 15:59:00.527 +08:00] [INFO] [session_token.go:198] ["signing cert is loaded successfully"] ["cert path"=/Users/xhe/.tiup/data/U2jjZcE/tiproxy.crt] ["key path"=/Users/xhe/.tiup/data/U2jjZcE/tiproxy.key]
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

Enable tiproxy connection migration by default on playground

Signed-off-by: xhe <xw897002528@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Jan 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 29, 2024
Signed-off-by: xhe <xw897002528@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2024

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (271d5ea) 50.19% compared to head (6059a2d) 55.30%.

❗ Current head 6059a2d differs from pull request most recent head c0e1bee. Consider uploading reports for the commit c0e1bee to get more accurate results

Files Patch % Lines
components/playground/instance/tiproxy.go 0.00% 27 Missing ⚠️
components/playground/instance/tidb_config.go 50.00% 3 Missing and 1 partial ⚠️
components/playground/playground.go 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2372      +/-   ##
==========================================
+ Coverage   50.19%   55.30%   +5.11%     
==========================================
  Files         328      329       +1     
  Lines       35009    35059      +50     
==========================================
+ Hits        17571    19389    +1818     
+ Misses      15118    13334    -1784     
- Partials     2320     2336      +16     
Flag Coverage Δ
playground 15.32% <22.73%> (-0.01%) ⬇️
tiup 33.60% <ø> (ø)
unittest 22.24% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: xhe <xw897002528@gmail.com>
@kaaaaaaang kaaaaaaang merged commit 1ab96db into pingcap:master Mar 25, 2024
6 of 7 checks passed
@kaaaaaaang kaaaaaaang added this to the v1.15.0 milestone Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants