Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: fix panic if failed to start tiflash #543

Merged
merged 5 commits into from
Jun 30, 2020

Conversation

july2993
Copy link
Contributor

Fix #538

We always Wait the instances before, if it failed to start it will panic caused the Command is not initialized and started.

This PR make sure it only Wait the instance iff it's started successfully.

@july2993 july2993 requested review from lucklove and lonng June 28, 2020 05:05
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2020

Codecov Report

Merging #543 into master will increase coverage by 11.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #543       +/-   ##
===========================================
+ Coverage   39.84%   50.98%   +11.14%     
===========================================
  Files         201      220       +19     
  Lines       14847    15914     +1067     
===========================================
+ Hits         5916     8114     +2198     
+ Misses       8072     6693     -1379     
- Partials      859     1107      +248     
Flag Coverage Δ
#coverage 50.98% <ø> (+11.14%) ⬆️
Impacted Files Coverage Δ
...o/src/github.com/pingcap/tiup/server/store/sync.go 28.57% <0.00%> (-28.58%) ⬇️
....com/pingcap/tiup/pkg/cluster/clusterutil/retry.go 50.00% <0.00%> (-17.50%) ⬇️
go/src/github.com/pingcap/tiup/cmd/mirror.go 39.95% <0.00%> (-6.89%) ⬇️
...ingcap/tiup/components/playground/instance/tidb.go 85.36% <0.00%> (-5.34%) ⬇️
...ingcap/tiup/components/playground/instance/tikv.go 75.00% <0.00%> (-4.32%) ⬇️
go/src/github.com/pingcap/tiup/cmd/root.go 60.43% <0.00%> (-3.85%) ⬇️
...cap/tiup/components/playground/instance/tiflash.go 61.29% <0.00%> (-2.49%) ⬇️
...om/pingcap/tiup/components/cluster/command/root.go 43.03% <0.00%> (-2.24%) ⬇️
.../pingcap/tiup/components/playground/instance/pd.go 75.43% <0.00%> (-1.23%) ⬇️
...pingcap/tiup/components/cluster/command/destroy.go 62.00% <0.00%> (-1.16%) ⬇️
... and 116 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3b52b3...3a0ce19. Read the comment docs.

@july2993 july2993 added the type/bug-fix Categorizes PR as a bug-fix label Jun 29, 2020
@july2993
Copy link
Contributor Author

@lonng PTAL

Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonng
Copy link
Contributor

lonng commented Jun 30, 2020

/merge

@lucklove lucklove merged commit 03a00c0 into pingcap:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug-fix Categorizes PR as a bug-fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiup playground panic
4 participants