Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a more general way to config profile #578

Merged
merged 4 commits into from
Jul 9, 2020

Conversation

lucklove
Copy link
Member

@lucklove lucklove commented Jul 6, 2020

Fix #104

Signed-off-by: lucklove gnu.crazier@gmail.com

Fix pingcap#104

Signed-off-by: lucklove <gnu.crazier@gmail.com>
@lucklove lucklove requested a review from july2993 July 6, 2020 08:39
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2020

Codecov Report

Merging #578 into master will increase coverage by 10.79%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #578       +/-   ##
===========================================
+ Coverage   39.84%   50.64%   +10.79%     
===========================================
  Files         201      219       +18     
  Lines       14847    15897     +1050     
===========================================
+ Hits         5916     8051     +2135     
+ Misses       8072     6725     -1347     
- Partials      859     1121      +262     
Flag Coverage Δ
#coverage 50.64% <ø> (+10.79%) ⬆️
Impacted Files Coverage Δ
...o/src/github.com/pingcap/tiup/server/store/sync.go 28.57% <0.00%> (-28.58%) ⬇️
go/src/github.com/pingcap/tiup/cmd/mirror.go 39.95% <0.00%> (-6.89%) ⬇️
...ingcap/tiup/components/playground/instance/tidb.go 85.36% <0.00%> (-5.34%) ⬇️
...ingcap/tiup/components/playground/instance/tikv.go 75.00% <0.00%> (-4.32%) ⬇️
go/src/github.com/pingcap/tiup/cmd/root.go 60.43% <0.00%> (-3.85%) ⬇️
...pingcap/tiup/components/cluster/command/destroy.go 60.37% <0.00%> (-2.79%) ⬇️
...cap/tiup/components/playground/instance/tiflash.go 61.29% <0.00%> (-2.49%) ⬇️
...om/pingcap/tiup/components/cluster/command/test.go 62.22% <0.00%> (-2.07%) ⬇️
...om/pingcap/tiup/components/cluster/command/root.go 43.39% <0.00%> (-1.88%) ⬇️
...m/pingcap/tiup/components/cluster/command/start.go 65.00% <0.00%> (-1.67%) ⬇️
... and 122 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 039853a...7414743. Read the comment docs.

install.sh Show resolved Hide resolved
@lucklove lucklove force-pushed the profile branch 9 times, most recently from b8b0f0e to 5c39b93 Compare July 7, 2020 13:34
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
@lucklove lucklove added the type/enhancement Categorizes issue or PR as related to an enhancement. label Jul 8, 2020
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 8, 2020
@ti-srebot
Copy link
Contributor

@lonng,Thanks for your review.

@lonng
Copy link
Contributor

lonng commented Jul 8, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2020
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ lucklove
❌ ti-srebot
You have signed the CLA already but the status is still pending? Let us recheck it.

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@lucklove merge failed.

@lonng lonng merged commit 02e306d into pingcap:master Jul 9, 2020
@lonng lonng deleted the profile branch July 9, 2020 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/enhancement Categorizes issue or PR as related to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write to .bashrc if .bash_profile doesn't exist?
5 participants