Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix init config with check config #583

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Conversation

lucklove
Copy link
Member

@lucklove lucklove commented Jul 7, 2020

Signed-off-by: lucklove gnu.crazier@gmail.com

What problem does this PR solve?

The scale-in process doesn't need to check config at all. But it still fails when other errors in the config check stage threw.

What is changed and how it works?

All errors in the config check stage should be config check error

Signed-off-by: lucklove <gnu.crazier@gmail.com>
@ti-srebot
Copy link
Contributor

@AstroProfundis,Thanks for your review.

@codecov-commenter
Copy link

Codecov Report

Merging #583 into master will increase coverage by 9.61%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
+ Coverage   39.84%   49.45%   +9.61%     
==========================================
  Files         201      218      +17     
  Lines       14847    15807     +960     
==========================================
+ Hits         5916     7818    +1902     
+ Misses       8072     6903    -1169     
- Partials      859     1086     +227     
Flag Coverage Δ
#coverage 49.45% <ø> (+9.61%) ⬆️
Impacted Files Coverage Δ
...o/src/github.com/pingcap/tiup/server/store/sync.go 28.57% <0.00%> (-28.58%) ⬇️
....com/pingcap/tiup/pkg/cluster/clusterutil/retry.go 50.00% <0.00%> (-17.50%) ⬇️
go/src/github.com/pingcap/tiup/cmd/mirror.go 39.95% <0.00%> (-6.89%) ⬇️
...ingcap/tiup/components/playground/instance/tidb.go 85.36% <0.00%> (-5.34%) ⬇️
...ingcap/tiup/components/playground/instance/tikv.go 75.00% <0.00%> (-4.32%) ⬇️
go/src/github.com/pingcap/tiup/cmd/root.go 60.43% <0.00%> (-3.85%) ⬇️
...cap/tiup/components/playground/instance/tiflash.go 61.29% <0.00%> (-2.49%) ⬇️
...om/pingcap/tiup/components/cluster/command/root.go 43.03% <0.00%> (-2.24%) ⬇️
.../pingcap/tiup/components/playground/instance/pd.go 75.43% <0.00%> (-1.23%) ⬇️
...pingcap/tiup/components/cluster/command/destroy.go 62.00% <0.00%> (-1.16%) ⬇️
... and 115 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e2469a...6c7b9a6. Read the comment docs.

@lucklove lucklove merged commit c391ff5 into pingcap:master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants