Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude files from npm package #471

Closed
wants to merge 1 commit into from
Closed

Conversation

viceice
Copy link

@viceice viceice commented Oct 11, 2023

Those files shouldn't be inside the npm package. Otherwise they can cause side effects.

https://github.com/containerbase/base/actions/runs/6480142703/job/17595082781?pr=1562

@jsumners
Copy link
Member

Thank you for your interest in this topic. Please see the discussion in fastify/skeleton#42 (comment) for my reasoning against such a change.

@viceice
Copy link
Author

viceice commented Oct 11, 2023

but the test files are a blocker for upgrade since you moved them to the lib folder

@jsumners
Copy link
Member

I don't know how that is the case.

@viceice
Copy link
Author

viceice commented Oct 12, 2023

@viceice viceice closed this Oct 12, 2023
@viceice viceice deleted the patch-1 branch October 12, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants