Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add injection of lacking arguments of customPrettifiers #501

Merged
merged 4 commits into from
Jun 9, 2024
Merged

fix: add injection of lacking arguments of customPrettifiers #501

merged 4 commits into from
Jun 9, 2024

Conversation

pasha-vuiko
Copy link
Contributor

resolves #500

@pasha-vuiko pasha-vuiko mentioned this pull request Mar 24, 2024
Closed
mcollina
mcollina requested changes Mar 25, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR! Can you please add a unit test?

@pasha-vuiko
Copy link
Contributor Author

Thanks for opening a PR! Can you please add a unit test?

done

@pasha-vuiko pasha-vuiko changed the title fix: add injection lacking arguments of customPrettifiers fix: add injection of lacking arguments of customPrettifiers Mar 26, 2024
mcollina
mcollina approved these changes Mar 31, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jsumners
jsumners requested changes Mar 31, 2024
View reviewed changes
lib/utils/prettify-metadata.test.js Outdated Show resolved Hide resolved
@pasha-vuiko
Copy link
Contributor Author

@jsumners could you re-review please?

@pasha-vuiko
Copy link
Contributor Author

@jsumners hey 👋, what about re-review?🙂

@jsumners jsumners merged commit 84680aa into pinojs:master Jun 9, 2024
5 checks passed
renovate bot added a commit to fwouts/previewjs that referenced this pull request Jun 16, 2024
@renovate
chore(deps): update dependency pino-pretty to ^11.2.1 (#2719)
41bafac 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [pino-pretty](https://togithub.com/pinojs/pino-pretty) | [`^11.1.0` ->
`^11.2.1`](https://renovatebot.com/diffs/npm/pino-pretty/11.1.0/11.2.1)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/pino-pretty/11.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino-pretty/11.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino-pretty/11.1.0/11.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino-pretty/11.1.0/11.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pinojs/pino-pretty (pino-pretty)</summary>

###
[`v11.2.1`](https://togithub.com/pinojs/pino-pretty/releases/tag/v11.2.1):
v11

[Compare
Source](https://togithub.com/pinojs/pino-pretty/compare/v11.2.0...v11.2.1)

#### What's Changed

- Fix: add missing useOnlyCustomProps options to type definitions by
[@&#8203;pcdevil](https://togithub.com/pcdevil) in
[pinojs/pino-pretty#514

#### New Contributors

- [@&#8203;pcdevil](https://togithub.com/pcdevil) made their first
contribution in
[pinojs/pino-pretty#514

**Full Changelog**:
pinojs/pino-pretty@v11.2.0...v11.2.1

###
[`v11.2.0`](https://togithub.com/pinojs/pino-pretty/releases/tag/v11.2.0)

[Compare
Source](https://togithub.com/pinojs/pino-pretty/compare/v11.1.0...v11.2.0)

#### What's Changed

- fix: add injection of lacking arguments of customPrettifiers by
[@&#8203;pasha-vuiko](https://togithub.com/pasha-vuiko) in
[pinojs/pino-pretty#501

#### New Contributors

- [@&#8203;pasha-vuiko](https://togithub.com/pasha-vuiko) made their
first contribution in
[pinojs/pino-pretty#501

**Full Changelog**:
pinojs/pino-pretty@v11.1.0...v11.2.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/fwouts/previewjs).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jsumners jsumners jsumners approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PinoPretty.customPrettifiers() lacks arguments declared in type PinoPretty.Prettifier
3 participants
@pasha-vuiko @mcollina @jsumners