Add ability to override custom levels comparison #1883

obrus-corcentric · 2024-01-16T13:11:01Z

No description provided.

mcollina

A few things are missing:

test for the new type (we use tsd)
docs for the new option

lib/levels.js

obrus-corcentric · 2024-01-17T09:47:08Z

A few things are missing:

test for the new type (we use tsd)

docs for the new option

Updated doc and types tests

mcollina

lgtm

lib/levels.js

lib/constants.js

lib/levels.js

jsumners · 2024-01-18T13:17:38Z

lib/levels.js

+ * @param {SORTING_ORDER} direction
+ * @param {number} current
+ * @param {number} expected


These params should have descriptions to explain their purposes.

jsumners · 2024-01-18T13:20:05Z

lib/levels.js

+ * @param {number} expected
+ * @returns {boolean}
+ */
+function compareLevel (direction, current, expected) {


Would this be a clearer signature?

Suggested change

function compareLevel (direction, current, expected) {

function isLevelEnabled (levelValue, threshold, sortOrder = SORTING_ORDER.DESC) {

The signature of this function starts from order to be able to create a single sorting function using bind with predefined first argument direction.

lib/levels.js

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino](https://getpino.io) ([source](https://togithub.com/pinojs/pino)) | [`^8.17.2` -> `^8.18.0`](https://renovatebot.com/diffs/npm/pino/8.17.2/8.18.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/pino/8.18.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino/8.18.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino/8.17.2/8.18.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino/8.17.2/8.18.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino (pino)</summary> ### [`v8.18.0`](https://togithub.com/pinojs/pino/releases/tag/v8.18.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.17.2...v8.18.0) #### What's Changed - build(deps): bump actions/upload-artifact from 3 to 4 by [@dependabot](https://togithub.com/dependabot) in [pinojs/pino#1873 - chore(license): Update licensing year by [@codershiba](https://togithub.com/codershiba) in [pinojs/pino#1882 - fix: destination docs and types by [@codershiba](https://togithub.com/codershiba) in [pinojs/pino#1881 - Correct type of `pino`'s `stream` parameter by [@quisido](https://togithub.com/quisido) in [pinojs/pino#1874 - Add ability to override custom levels comparison by [@obrus-corcentric](https://togithub.com/obrus-corcentric) in [pinojs/pino#1883 - build(deps-dev): bump tsd from 0.29.0 to 0.30.4 by [@dependabot](https://togithub.com/dependabot) in [pinojs/pino#1888 #### New Contributors - [@codershiba](https://togithub.com/codershiba) made their first contribution in [pinojs/pino#1882 - [@quisido](https://togithub.com/quisido) made their first contribution in [pinojs/pino#1874 - [@obrus-corcentric](https://togithub.com/obrus-corcentric) made their first contribution in [pinojs/pino#1883 **Full Changelog**: pinojs/pino@v8.17.2...v8.18.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/fwouts/previewjs).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino](https://getpino.io) ([source](https://togithub.com/pinojs/pino)) | [`8.16.2` -> `8.19.0`](https://renovatebot.com/diffs/npm/pino/8.16.2/8.19.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/pino/8.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino/8.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino/8.16.2/8.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino/8.16.2/8.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino (pino)</summary> ### [`v8.19.0`](https://togithub.com/pinojs/pino/releases/tag/v8.19.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.18.0...v8.19.0) #### What's Changed - api.md: Fix link declaration by [@homersimpsons](https://togithub.com/homersimpsons) in [pinojs/pino#1900 - Update transports.md by [@huijiewei](https://togithub.com/huijiewei) in [pinojs/pino#1897 - Add a basic `formatters` option to the browser pino by [@KatelynKim](https://togithub.com/KatelynKim) in [pinojs/pino#1898 - `setLevel` should respect level comparison option by [@obrus-corcentric](https://togithub.com/obrus-corcentric) in [pinojs/pino#1901 - Add formatters log option by [@KatelynKim](https://togithub.com/KatelynKim) in [pinojs/pino#1905 #### New Contributors - [@homersimpsons](https://togithub.com/homersimpsons) made their first contribution in [pinojs/pino#1900 - [@huijiewei](https://togithub.com/huijiewei) made their first contribution in [pinojs/pino#1897 - [@KatelynKim](https://togithub.com/KatelynKim) made their first contribution in [pinojs/pino#1898 **Full Changelog**: pinojs/pino@v8.18.0...v8.19.0 ### [`v8.18.0`](https://togithub.com/pinojs/pino/releases/tag/v8.18.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.17.2...v8.18.0) #### What's Changed - build(deps): bump actions/upload-artifact from 3 to 4 by [@dependabot](https://togithub.com/dependabot) in [pinojs/pino#1873 - chore(license): Update licensing year by [@codershiba](https://togithub.com/codershiba) in [pinojs/pino#1882 - fix: destination docs and types by [@codershiba](https://togithub.com/codershiba) in [pinojs/pino#1881 - Correct type of `pino`'s `stream` parameter by [@quisido](https://togithub.com/quisido) in [pinojs/pino#1874 - Add ability to override custom levels comparison by [@obrus-corcentric](https://togithub.com/obrus-corcentric) in [pinojs/pino#1883 - build(deps-dev): bump tsd from 0.29.0 to 0.30.4 by [@dependabot](https://togithub.com/dependabot) in [pinojs/pino#1888 #### New Contributors - [@codershiba](https://togithub.com/codershiba) made their first contribution in [pinojs/pino#1882 - [@quisido](https://togithub.com/quisido) made their first contribution in [pinojs/pino#1874 - [@obrus-corcentric](https://togithub.com/obrus-corcentric) made their first contribution in [pinojs/pino#1883 **Full Changelog**: pinojs/pino@v8.17.2...v8.18.0 ### [`v8.17.2`](https://togithub.com/pinojs/pino/releases/tag/v8.17.2) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.17.1...v8.17.2) #### What's Changed - build(deps): bump process-warning from 2.3.2 to 3.0.0 by [@dependabot](https://togithub.com/dependabot) in [pinojs/pino#1869 - fix: type of child logger with custom levels by [@UndefinedBehaviour](https://togithub.com/UndefinedBehaviour) in [pinojs/pino#1871 **Full Changelog**: pinojs/pino@v8.17.1...v8.17.2 ### [`v8.17.1`](https://togithub.com/pinojs/pino/releases/tag/v8.17.1) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.17.0...v8.17.1) #### What's Changed - Support unknown, reverts 1783, add tests by [@mcollina](https://togithub.com/mcollina) in [pinojs/pino#1866 - Add Type Example for custom logger by [@mcollina](https://togithub.com/mcollina) in [pinojs/pino#1867 **Full Changelog**: pinojs/pino@v8.17.0...v8.17.1 ### [`v8.17.0`](https://togithub.com/pinojs/pino/releases/tag/v8.17.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.16.2...v8.17.0) #### What's Changed - build(deps): bump actions/github-script from 6 to 7 by [@dependabot](https://togithub.com/dependabot) in [pinojs/pino#1857 - Make license detectable by GitHub by [@10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) in [pinojs/pino#1859 - docs: Clarify how to log both to a custom transport and to stdout by [@kibertoad](https://togithub.com/kibertoad) in [pinojs/pino#1860 - Fix/types by [@UndefinedBehaviour](https://togithub.com/UndefinedBehaviour) in [pinojs/pino#1858 - Bumped tsd to v0.29.0 by [@mcollina](https://togithub.com/mcollina) in [pinojs/pino#1863 - fix: typescript types by [@Zamiell](https://togithub.com/Zamiell) in [pinojs/pino#1783 - build(deps): bump pnpm/action-setup from 2.2.4 to 2.4.0 by [@dependabot](https://togithub.com/dependabot) in [pinojs/pino#1766 #### New Contributors - [@10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) made their first contribution in [pinojs/pino#1859 - [@Zamiell](https://togithub.com/Zamiell) made their first contribution in [pinojs/pino#1783 **Full Changelog**: pinojs/pino@v8.16.2...v8.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: David Price <thedavid@thedavidprice.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino](https://getpino.io) ([source](https://togithub.com/pinojs/pino)) | [`8.17.2` -> `8.19.0`](https://renovatebot.com/diffs/npm/pino/8.17.2/8.19.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/pino/8.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino/8.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino/8.17.2/8.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino/8.17.2/8.19.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino (pino)</summary> ### [`v8.19.0`](https://togithub.com/pinojs/pino/releases/tag/v8.19.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.18.0...v8.19.0) #### What's Changed - api.md: Fix link declaration by [@homersimpsons](https://togithub.com/homersimpsons) in [pinojs/pino#1900 - Update transports.md by [@huijiewei](https://togithub.com/huijiewei) in [pinojs/pino#1897 - Add a basic `formatters` option to the browser pino by [@KatelynKim](https://togithub.com/KatelynKim) in [pinojs/pino#1898 - `setLevel` should respect level comparison option by [@obrus-corcentric](https://togithub.com/obrus-corcentric) in [pinojs/pino#1901 - Add formatters log option by [@KatelynKim](https://togithub.com/KatelynKim) in [pinojs/pino#1905 #### New Contributors - [@homersimpsons](https://togithub.com/homersimpsons) made their first contribution in [pinojs/pino#1900 - [@huijiewei](https://togithub.com/huijiewei) made their first contribution in [pinojs/pino#1897 - [@KatelynKim](https://togithub.com/KatelynKim) made their first contribution in [pinojs/pino#1898 **Full Changelog**: pinojs/pino@v8.18.0...v8.19.0 ### [`v8.18.0`](https://togithub.com/pinojs/pino/releases/tag/v8.18.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.17.2...v8.18.0) #### What's Changed - build(deps): bump actions/upload-artifact from 3 to 4 by [@dependabot](https://togithub.com/dependabot) in [pinojs/pino#1873 - chore(license): Update licensing year by [@codershiba](https://togithub.com/codershiba) in [pinojs/pino#1882 - fix: destination docs and types by [@codershiba](https://togithub.com/codershiba) in [pinojs/pino#1881 - Correct type of `pino`'s `stream` parameter by [@quisido](https://togithub.com/quisido) in [pinojs/pino#1874 - Add ability to override custom levels comparison by [@obrus-corcentric](https://togithub.com/obrus-corcentric) in [pinojs/pino#1883 - build(deps-dev): bump tsd from 0.29.0 to 0.30.4 by [@dependabot](https://togithub.com/dependabot) in [pinojs/pino#1888 #### New Contributors - [@codershiba](https://togithub.com/codershiba) made their first contribution in [pinojs/pino#1882 - [@quisido](https://togithub.com/quisido) made their first contribution in [pinojs/pino#1874 - [@obrus-corcentric](https://togithub.com/obrus-corcentric) made their first contribution in [pinojs/pino#1883 **Full Changelog**: pinojs/pino@v8.17.2...v8.18.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 10am on Friday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ettorepuccetti/terrarossa).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

feat: add ability to override custom levels compare

3bb58e5

obrus-corcentric mentioned this pull request Jan 16, 2024

Allow custom levels comparison #1880

Closed

mcollina requested changes Jan 16, 2024

View reviewed changes

lib/levels.js Show resolved Hide resolved

obrus-corcentric added 3 commits January 17, 2024 11:42

fix: use function instead of closure

bd953e1

docs: update level comparison to docs

8b74f04

test: update types tests for level comparison

fac044e

obrus-corcentric requested a review from mcollina January 17, 2024 09:47

mcollina approved these changes Jan 17, 2024

View reviewed changes

mcollina requested a review from jsumners January 17, 2024 09:54

jsumners reviewed Jan 17, 2024

View reviewed changes

lib/levels.js Outdated Show resolved Hide resolved

lib/levels.js Show resolved Hide resolved

lib/levels.js Outdated Show resolved Hide resolved

refactor: move default levels and sorting order to constants

00c9828

jsumners requested changes Jan 18, 2024

View reviewed changes

obrus-corcentric added 2 commits January 19, 2024 09:52

fix: made suggested changes in pr review

476b1f4

fix: change enum annotation type

66a83f9

jsumners approved these changes Jan 22, 2024

View reviewed changes

mcollina merged commit 384df31 into pinojs:master Feb 1, 2024
18 of 21 checks passed

obrus-corcentric mentioned this pull request Feb 9, 2024

setLevel should respect level comparison option #1901

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ability to override custom levels comparison #1883

Add ability to override custom levels comparison #1883

obrus-corcentric commented Jan 16, 2024

mcollina left a comment

obrus-corcentric commented Jan 17, 2024

mcollina left a comment

jsumners Jan 18, 2024

jsumners Jan 18, 2024

obrus-corcentric Jan 19, 2024

	function compareLevel (direction, current, expected) {
	function isLevelEnabled (levelValue, threshold, sortOrder = SORTING_ORDER.DESC) {

Add ability to override custom levels comparison #1883

Add ability to override custom levels comparison #1883

Conversation

obrus-corcentric commented Jan 16, 2024

mcollina left a comment

Choose a reason for hiding this comment

obrus-corcentric commented Jan 17, 2024

mcollina left a comment

Choose a reason for hiding this comment

jsumners Jan 18, 2024

Choose a reason for hiding this comment

jsumners Jan 18, 2024

Choose a reason for hiding this comment

obrus-corcentric Jan 19, 2024

Choose a reason for hiding this comment