-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(transport-stream): Fix import error when using pkg with node v20 #1949
Conversation
released |
Thank you! Could you please re-run the tests so I can check if everything's alright? (I don't see an option to re-run them myself) |
It’s failing unfortunately |
c2f12ac
to
e42db3d
Compare
I fixed the errors for Node v21. I was checking for stderr to be an empty string but it turns out it's a deprecation warning for punnycode:
So I added a regex test which checks exactly the warning above. Anything else will fail the test. For Node 18 on MacOS I assume it's not related to my commit since it fails on another test, which works in Linux and Windows. But please run the tests again, and if there is a problem on MacOS I'll look deeper into it. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino](https://getpino.io) ([source](https://togithub.com/pinojs/pino)) | [`^8.18.0` -> `^9.0.0`](https://renovatebot.com/diffs/npm/pino/8.21.0/9.1.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/pino/9.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino/9.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino/8.21.0/9.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino/8.21.0/9.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino (pino)</summary> ### [`v9.1.0`](https://togithub.com/pinojs/pino/releases/tag/v9.1.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v9.0.0...v9.1.0) #### What's Changed - fix(transport-stream): Fix import error when using pkg with node v20 by [@​nagyszabi](https://togithub.com/nagyszabi) in [pinojs/pino#1949 - Update LTS doc by [@​jsumners](https://togithub.com/jsumners) in [pinojs/pino#1955 - Update pino types for browser.formatters by [@​KatelynKim](https://togithub.com/KatelynKim) in [pinojs/pino#1946 - add node v22 to CI by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1953 - Add Platformatic to sponsors by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1956 - Update h3 example by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1968 - Support file URLs when configuring multiple transports by [@​haines](https://togithub.com/haines) in [pinojs/pino#1961 - Adding support for mix\&match pipelines by [@​dbacarel](https://togithub.com/dbacarel) in [pinojs/pino#1954 - apply serializers to args once before asObject or transmit by [@​emmyakin](https://togithub.com/emmyakin) in [pinojs/pino#1971 - build(deps-dev): bump pino-pretty from 10.3.1 to 11.0.0 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1933 - build(deps): bump sonic-boom from 3.8.1 to 4.0.1 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1960 - build(deps): bump pino-std-serializers from 6.2.2 to 7.0.0 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1957 - build(deps-dev): bump tsd from 0.30.7 to 0.31.0 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1937 - build(deps): bump actions/dependency-review-action from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1894 - build(deps): bump pnpm/action-setup from 2.4.0 to 3.0.0 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1913 - Drop yarn support and update pnpm by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1972 - build(deps): bump thread-stream from 2.7.0 to 3.0.0 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1959 #### New Contributors - [@​nagyszabi](https://togithub.com/nagyszabi) made their first contribution in [pinojs/pino#1949 - [@​haines](https://togithub.com/haines) made their first contribution in [pinojs/pino#1961 - [@​emmyakin](https://togithub.com/emmyakin) made their first contribution in [pinojs/pino#1971 **Full Changelog**: pinojs/pino@v9.0.0...v9.1.0 ### [`v9.0.0`](https://togithub.com/pinojs/pino/compare/v8.21.0...4f8ea32aa69ec94b2fb5561716a7701aec991ce7) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.21.0...v9.0.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/rustymotors/server). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjM1MS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino](https://getpino.io) ([source](https://togithub.com/pinojs/pino)) | [`8.21.0` -> `9.3.1`](https://renovatebot.com/diffs/npm/pino/8.21.0/9.3.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/pino/9.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino/9.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino/8.21.0/9.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino/8.21.0/9.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino (pino)</summary> ### [`v9.3.1`](https://togithub.com/pinojs/pino/releases/tag/v9.3.1) [Compare Source](https://togithub.com/pinojs/pino/compare/v9.3.0...v9.3.1) **Full Changelog**: pinojs/pino@v9.3.0...v9.3.1 ### [`v9.3.0`](https://togithub.com/pinojs/pino/compare/v9.2.0...92f2cee98e83d3f864b228a6e1dc29a31e54ba49) [Compare Source](https://togithub.com/pinojs/pino/compare/v9.2.0...v9.3.0) ### [`v9.2.0`](https://togithub.com/pinojs/pino/releases/tag/v9.2.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v9.1.0...v9.2.0) #### What's Changed - shallow clone target options by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1973 - add logger instance as third parameter by [@​emmyakin](https://togithub.com/emmyakin) in [pinojs/pino#1977 - use boolean flag to ensure serializers are applied once by [@​emmyakin](https://togithub.com/emmyakin) in [pinojs/pino#1976 - suppport messageKey in pino/browser by [@​emmyakin](https://togithub.com/emmyakin) in [pinojs/pino#1980 - Fixing browser side child log issue ([#​960](https://togithub.com/pinojs/pino/issues/960)) child level can now be set at cr… by [@​stevel032](https://togithub.com/stevel032) in [pinojs/pino#1986 #### New Contributors - [@​stevel032](https://togithub.com/stevel032) made their first contribution in [pinojs/pino#1986 **Full Changelog**: pinojs/pino@v9.1.0...v9.2.0 ### [`v9.1.0`](https://togithub.com/pinojs/pino/releases/tag/v9.1.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v9.0.0...v9.1.0) #### What's Changed - fix(transport-stream): Fix import error when using pkg with node v20 by [@​nagyszabi](https://togithub.com/nagyszabi) in [pinojs/pino#1949 - Update LTS doc by [@​jsumners](https://togithub.com/jsumners) in [pinojs/pino#1955 - Update pino types for browser.formatters by [@​KatelynKim](https://togithub.com/KatelynKim) in [pinojs/pino#1946 - add node v22 to CI by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1953 - Add Platformatic to sponsors by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1956 - Update h3 example by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1968 - Support file URLs when configuring multiple transports by [@​haines](https://togithub.com/haines) in [pinojs/pino#1961 - Adding support for mix\&match pipelines by [@​dbacarel](https://togithub.com/dbacarel) in [pinojs/pino#1954 - apply serializers to args once before asObject or transmit by [@​emmyakin](https://togithub.com/emmyakin) in [pinojs/pino#1971 - build(deps-dev): bump pino-pretty from 10.3.1 to 11.0.0 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1933 - build(deps): bump sonic-boom from 3.8.1 to 4.0.1 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1960 - build(deps): bump pino-std-serializers from 6.2.2 to 7.0.0 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1957 - build(deps-dev): bump tsd from 0.30.7 to 0.31.0 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1937 - build(deps): bump actions/dependency-review-action from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1894 - build(deps): bump pnpm/action-setup from 2.4.0 to 3.0.0 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1913 - Drop yarn support and update pnpm by [@​mcollina](https://togithub.com/mcollina) in [pinojs/pino#1972 - build(deps): bump thread-stream from 2.7.0 to 3.0.0 by [@​dependabot](https://togithub.com/dependabot) in [pinojs/pino#1959 #### New Contributors - [@​nagyszabi](https://togithub.com/nagyszabi) made their first contribution in [pinojs/pino#1949 - [@​haines](https://togithub.com/haines) made their first contribution in [pinojs/pino#1961 - [@​emmyakin](https://togithub.com/emmyakin) made their first contribution in [pinojs/pino#1971 **Full Changelog**: pinojs/pino@v9.0.0...v9.1.0 ### [`v9.0.0`](https://togithub.com/pinojs/pino/compare/v8.21.0...4f8ea32aa69ec94b2fb5561716a7701aec991ce7) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.21.0...v9.0.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Fixes: #1948
Note:
Because the changes to
thread-stream
aren't published yet, tests will fail.I tested the code locally, where I manually changed the
thread-stream
package in order to be able to test the changes.