pass merging object to mixins #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madelinecameron
commented
Nov 13, 2020
| @@ -147,9 +147,9 @@ function write (_obj, msg, num) { | |||
| var obj | |||
|
|
|||
| if (_obj === undefined || _obj === null) { | |||
| obj = mixin ? mixin() : {} | |||
| obj = mixin ? mixin({}) : {} | |||
There was a problem hiding this comment.
Not totally needed, just figured I'd be nice and pass an empty object. 🤷
|
Will add a test shortly, sorry about that. :) |
mcollina
requested changes
Nov 13, 2020
|
This is also missing some docs update |
|
Yep, was wondering about that, I'll do that. Thanks! |
|
Took a crack at integrating it to documentation, let me know any feedback. :) |
mcollina
reviewed
Nov 13, 2020
| @@ -124,7 +124,7 @@ const mixin = { | |||
| } | |||
|
|
|||
| const logger = pino({ | |||
| mixin() { | |||
| mixin({ description }) { | |||
There was a problem hiding this comment.
let's name the paramenter obj, without destructuring
jsumners
approved these changes
Nov 15, 2020
hraban
added a commit
to hraban/pino
that referenced
this pull request
Jan 15, 2021
Restores the original semantics introduced by afb639c (pinojs#857). Reverts the changes to this documentation from 6e50d72 (pinojs#928) and 6c42f14 (pinojs#926).
Merged
hraban
added a commit
to hraban/pino
that referenced
this pull request
Jan 15, 2021
Restores the original semantics introduced by afb639c (pinojs#857). Reverts the changes to this documentation from 6e50d72 (pinojs#928) and 6c42f14 (pinojs#926). Fixes pinojs#951.
This was referenced Mar 15, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for mixins to take in an object and add information contextually.
For instance, if your
mergingObjecthas anerrorkey (a JS Error), I want to add{ message: error.message, stack: error.stack }. This will make mixins more useful or having to pull from higher in the scope.