Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address destructuring mergeObject in docs #928

Merged
merged 1 commit into from
Nov 16, 2020
Merged

address destructuring mergeObject in docs #928

merged 1 commit into from
Nov 16, 2020

Conversation

madelinecameron
Copy link
Contributor

Follow-on to #926 to address this comment by @mcollina:

let's name the paramenter obj, without destructuring

jsumners
jsumners approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcollina
mcollina approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 6e50d72 into pinojs:master Nov 16, 2020
@madelinecameron madelinecameron deleted the fix-doc-destructuring branch November 16, 2020 19:53
@mcollina mcollina mentioned this pull request Jan 15, 2021
Closed
hraban added a commit to hraban/pino that referenced this pull request Jan 15, 2021
@hraban
docs: fix mixin docs
4c210eb 
Restores the original semantics introduced by afb639c (pinojs#857).

Reverts the changes to this documentation from 6e50d72 (pinojs#928) and
6c42f14 (pinojs#926).
@hraban hraban mentioned this pull request Jan 15, 2021
Merged
hraban added a commit to hraban/pino that referenced this pull request Jan 15, 2021
@hraban
docs: fix mixin docs
0996d8d 
Restores the original semantics introduced by afb639c (pinojs#857).

Reverts the changes to this documentation from 6e50d72 (pinojs#928) and
6c42f14 (pinojs#926).

Fixes pinojs#951.
mcollina pushed a commit that referenced this pull request Jan 15, 2021
@hraban
docs: fix mixin docs (#952)
6768d4e 
Restores the original semantics introduced by afb639c (#857).

Reverts the changes to this documentation from 6e50d72 (#928) and
6c42f14 (#926).

Fixes #951.
This was referenced Mar 15, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
@github-actions
Copy link

github-actions bot commented Feb 2, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcollina mcollina mcollina approved these changes

@jsumners jsumners jsumners approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@madelinecameron @mcollina @jsumners