[#NOISSUE] code cleanup

pinpoint-apm · Apr 11, 2023 · c757a04 · c757a04
1 parent 5cc4e04
commit c757a04
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 20 deletions.
diff --git a/...ic-module/metric/src/main/java/com/navercorp/pinpoint/metric/web/dao/SystemMetricDao.java b/...ic-module/metric/src/main/java/com/navercorp/pinpoint/metric/web/dao/SystemMetricDao.java
@@ -28,8 +28,5 @@
  */
 public interface SystemMetricDao<T extends Number> {
 
-    @Deprecated
-    List<SystemMetricPoint<T>> getSampledSystemMetricData(MetricDataSearchKey metricDataSearchKey, MetricTag metricTag);
-
     Future<List<SystemMetricPoint<T>>> getAsyncSampledSystemMetricData(MetricDataSearchKey metricDataSearchKey, MetricTag metricTag);
 }
diff --git a/...src/main/java/com/navercorp/pinpoint/metric/web/dao/pinot/PinotSystemMetricDoubleDao.java b/...src/main/java/com/navercorp/pinpoint/metric/web/dao/pinot/PinotSystemMetricDoubleDao.java
@@ -49,20 +49,6 @@ public PinotSystemMetricDoubleDao(SqlSessionTemplate sqlPinotSessionTemplate, Pi
         this.asyncTemplate = Objects.requireNonNull(asyncTemplate, "asyncTemplate");
     }
 
-    @Override
-    @Deprecated
-    public List<SystemMetricPoint<Double>> getSampledSystemMetricData(MetricDataSearchKey metricDataSearchKey, MetricTag metricTag) {
-        StopWatch watch = StopWatch.createStarted();
-        logger.info("=========== thread start {} thread. tag:{}", Thread.currentThread().getName(), metricTag);
-
-        SystemMetricDataSearchKey systemMetricDataSearchKey = new SystemMetricDataSearchKey(metricDataSearchKey, metricTag);
-        List<SystemMetricPoint<Double>> result = sqlPinotSessionTemplate.selectList(NAMESPACE + "selectSampledSystemMetricData", systemMetricDataSearchKey);
-
-        watch.stop();
-        logger.info("============ thread end {} thread. executeTime:{} tag:{}", Thread.currentThread().getName(), watch.getTime(), metricTag);
-        return result;
-    }
-
     @Override
     public Future<List<SystemMetricPoint<Double>>> getAsyncSampledSystemMetricData(MetricDataSearchKey metricDataSearchKey, MetricTag metricTag) {
         SystemMetricDataSearchKey systemMetricDataSearchKey = new SystemMetricDataSearchKey(metricDataSearchKey, metricTag);

diff --git a/.../src/main/java/com/navercorp/pinpoint/metric/web/service/SystemMetricDataServiceImpl.java b/.../src/main/java/com/navercorp/pinpoint/metric/web/service/SystemMetricDataServiceImpl.java
@@ -93,7 +93,6 @@ private List<MetricValue<? extends Number>> getMetricValues(MetricDataSearchKey
         Metric elementOfBasicGroupList = systemMetricBasicGroupManager.findElementOfBasicGroup(metricDataSearchKey.getMetricDefinitionId());
 
         StopWatch watch = StopWatch.createStarted();
-        logger.info("=========== thread start {} thread. metricDefinitionId:{}", Thread.currentThread().getName(), metricDataSearchKey.getMetricDefinitionId());
         List<QueryResult<Number>> queryResults = selectAll(metricDataSearchKey, elementOfBasicGroupList, tags);
 
         List<MetricValue<?>> metricValueList = new ArrayList<>(elementOfBasicGroupList.getFields().size());
@@ -111,12 +110,10 @@ private List<MetricValue<? extends Number>> getMetricValues(MetricDataSearchKey
                     StopWatch dataProcessWatch = StopWatch.createStarted();
                     MetricValue<Double> doubleMetricValue = createSystemMetricValue(timeWindow, result.getTag(), doubleList, DoubleUncollectedDataCreator.UNCOLLECTED_DATA_CREATOR);
                     dataProcessWatch.stop();
-                    logger.info("##### execute process data {} thread. processTime:{} metricDefinitionId:{}", Thread.currentThread().getName(), dataProcessWatch.getTime(), metricDataSearchKey.getMetricDefinitionId());
                     metricValueList.add(doubleMetricValue);
                 }
             }
 
-            logger.info("============ thread end {} thread. executeTime:{} metricDefinitionId:{}", Thread.currentThread().getName(), watch.getTime(), metricDataSearchKey.getMetricDefinitionId());
             watch.stop();
             return metricValueList;
         } catch (Throwable e) {