Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linenumber #9380

Closed
feelform opened this issue Nov 4, 2022 · 0 comments · Fixed by #9450
Closed

Linenumber #9380

feelform opened this issue Nov 4, 2022 · 0 comments · Fixed by #9450
Assignees
@feelform

Comments

@feelform
Copy link
Contributor

feelform commented Nov 4, 2022 •
edited
Loading

Line number in Source code
API Object nullability
Screenshot 2022-11-29 at 3 28 20 PM

API Object with Line number and location
Screenshot 2022-11-29 at 3 32 18 PM

Add Line number and location in APIMetaDataBO
If Line number is null, value 0
location value is nullable

  • Warning:(91, 29) 'StringBuilder sb' can be replaced with 'String'
  • Hbase must save data with null because of saved data order
  • Add linenumber and location in TransactionInfoViewModel
feelform added a commit to feelform/pinpoint that referenced this issue Nov 15, 2022
@feelform
[pinpoint-apm#9380] gRPC and protocol buffer unit tests for Line numb…
07667fb 
…er and location
feelform added a commit to feelform/pinpoint that referenced this issue Nov 21, 2022
@feelform
[pinpoint-apm#9380] gRPC lineNumber and location integration test
b638ad0
feelform added a commit to feelform/pinpoint that referenced this issue Nov 21, 2022
@feelform
[pinpoint-apm#9380] add location field
5dae10d 
Fix intelliJ warning
   * Warning:(91, 29) 'StringBuilder sb' can be replaced with 'String'
feelform added a commit to feelform/pinpoint that referenced this issue Nov 25, 2022
@feelform
[pinpoint-apm#9380] add location field
3c3979f 
Fix intelliJ warning
   * Warning:(91, 29) 'StringBuilder sb' can be replaced with 'String'
feelform added a commit to feelform/pinpoint that referenced this issue Nov 25, 2022
@feelform
[pinpoint-apm#9380] add location field
39ecdce 
Fix intelliJ warning
   * Warning:(91, 29) 'StringBuilder sb' can be replaced with 'String'
feelform added a commit to feelform/pinpoint that referenced this issue Nov 28, 2022
@feelform
[pinpoint-apm#9380] add location field
1af5e9a 
Fix intelliJ warning
   * Warning:(91, 29) 'StringBuilder sb' can be replaced with 'String'
feelform added a commit to feelform/pinpoint that referenced this issue Nov 28, 2022
@feelform
[pinpoint-apm#9380] Supports Line number and location in Callstack
b90c840 
Add Line number and location in APIMetaDataBO
If Line number is null, value `0`
location value is nullable
@feelform feelform self-assigned this Nov 29, 2022
feelform added a commit to feelform/pinpoint that referenced this issue Nov 30, 2022
@feelform
[pinpoint-apm#9380] add location field
f255d0d 
Fix intelliJ warning
   * Warning:(91, 29) 'StringBuilder sb' can be replaced with 'String'
feelform added a commit to feelform/pinpoint that referenced this issue Nov 30, 2022
@feelform
[pinpoint-apm#9380] add location field
3f3382c 
Fix intelliJ warning
   * Warning:(91, 29) 'StringBuilder sb' can be replaced with 'String'
feelform added a commit to feelform/pinpoint that referenced this issue Dec 2, 2022
@feelform
[pinpoint-apm#9380] Hbase must save data with null because of saved d…
7a2c740 
…ata order
feelform added a commit to feelform/pinpoint that referenced this issue Dec 2, 2022
@feelform
[pinpoint-apm#9380] Child size check
5b54ce2
feelform added a commit to feelform/pinpoint that referenced this issue Dec 7, 2022
@feelform
[pinpoint-apm#9380] Calltree verification Unit test
94c1334
feelform added a commit to feelform/pinpoint that referenced this issue Dec 9, 2022
@feelform
[pinpoint-apm#9380] Calltree verification Unit test
bc71edf
feelform added a commit to feelform/pinpoint that referenced this issue Dec 14, 2022
@feelform
[pinpoint-apm#9380] Calltree verification Unit test
fc0c66f
feelform added a commit to feelform/pinpoint that referenced this issue Dec 14, 2022
@feelform
[pinpoint-apm#9380] Calltree verification Unit test
ccd0305
feelform added a commit to feelform/pinpoint that referenced this issue Dec 15, 2022
@feelform
[pinpoint-apm#9380] Supports Line number and location in Callstack
5b16979 
Add Line number and location in APIMetaDataBO
If Line number is null, value `0`
location value is nullable
* Warning:(91, 29) 'StringBuilder sb' can be replaced with 'String'
* Hbase must save data with null because of saved data order
* Add linenumber and location in TransactionInfoViewModel
feelform added a commit to feelform/pinpoint that referenced this issue Dec 19, 2022
@feelform
[pinpoint-apm#9380] Supports Line number and location in Callstack
8e7659b 
Add Line number and location in APIMetaDataBO
If Line number is null, value `0`
location value is nullable
* Warning:(91, 29) 'StringBuilder sb' can be replaced with 'String'
* Hbase must save data with null because of saved data order
* Add linenumber and location in TransactionInfoViewModel
@feelform feelform mentioned this issue Dec 19, 2022
Merged
feelform added a commit to feelform/pinpoint that referenced this issue Dec 21, 2022
@feelform
[pinpoint-apm#9380] Supports Line number and location in Callstack
d0b715f 
Add Line number and location in APIMetaDataBO
If Line number is null, value `0`
location value is nullable
* Warning:(91, 29) 'StringBuilder sb' can be replaced with 'String'
* Hbase must save data with null because of saved data order
* Add linenumber and location in TransactionInfoViewModel
@emeroad emeroad linked a pull request Dec 21, 2022 that will close this issue
[#9380] Supports Line number and location in Callstack #9450
Merged
emeroad pushed a commit that referenced this issue Dec 21, 2022
@feelform @emeroad
[#9380] Supports Line number and location in Callstack
0eb0596 
Add Line number and location in APIMetaDataBO
If Line number is null, value `0`
location value is nullable
* Warning:(91, 29) 'StringBuilder sb' can be replaced with 'String'
* Hbase must save data with null because of saved data order
* Add linenumber and location in TransactionInfoViewModel
binDongKim added a commit to binDongKim/pinpoint that referenced this issue Jan 5, 2023
@binDongKim
[pinpoint-apm#9380] Add line-number and location info on call-tree
663cf71
binDongKim added a commit that referenced this issue Jan 5, 2023
@binDongKim
[#9380] Add line-number and location info on call-tree
cd0e97e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feelform feelform

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#9380] Supports Line number and location in Callstack feelform/pinpoint
1 participant
@feelform