Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#9380] Supports Line number and location in Callstack #9450

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

feelform
Copy link
Contributor

@feelform feelform commented Nov 30, 2022

Add Line number and location in APIMetaDataBO
If Line number is null, value 0
location value is nullable

ref #9380

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #9450 (8e7659b) into master (2f706e2) will increase coverage by 0.42%.
The diff coverage is 40.92%.

❗ Current head 8e7659b differs from pull request most recent head d0b715f. Consider uploading reports for the commit d0b715f to get more accurate results

@@             Coverage Diff              @@
##             master    #9450      +/-   ##
============================================
+ Coverage     38.44%   38.86%   +0.42%     
- Complexity    11764    11903     +139     
============================================
  Files          3484     3484              
  Lines         93619    93822     +203     
  Branches      10527    10534       +7     
============================================
+ Hits          35988    36462     +474     
+ Misses        54506    54189     -317     
- Partials       3125     3171      +46     
Impacted Files Coverage Δ
...ercorp/pinpoint/common/server/bo/AnnotationBo.java 26.92% <0.00%> (-14.26%) ⬇️
...om/navercorp/pinpoint/common/server/bo/SpanBo.java 37.65% <0.00%> (-22.75%) ⬇️
...vercorp/pinpoint/common/server/bo/SpanEventBo.java 36.60% <0.00%> (-14.78%) ⬇️
...t/web/view/TransactionInfoCallStackSerializer.java 0.00% <0.00%> (ø)
...rp/pinpoint/web/view/TransactionInfoViewModel.java 0.00% <0.00%> (ø)
...vercorp/pinpoint/web/vo/callstacks/BaseRecord.java 7.76% <50.00%> (+2.71%) ⬆️
...vercorp/pinpoint/web/mapper/ApiMetaDataMapper.java 74.28% <71.42%> (+74.28%) ⬆️
...pinpoint/common/server/trace/DefaultApiParser.java 76.47% <80.00%> (+76.47%) ⬆️
...rcorp/pinpoint/web/calltree/span/CallTreeNode.java 90.32% <80.00%> (-4.92%) ⬇️
...corp/pinpoint/web/vo/callstacks/DefaultRecord.java 75.71% <83.33%> (+75.71%) ⬆️
... and 39 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@feelform feelform force-pushed the linenumber branch 2 times, most recently from 5b16979 to 8e7659b Compare December 19, 2022 08:37
Add Line number and location in APIMetaDataBO
If Line number is null, value `0`
location value is nullable
* Warning:(91, 29) 'StringBuilder sb' can be replaced with 'String'
* Hbase must save data with null because of saved data order
* Add linenumber and location in TransactionInfoViewModel
@emeroad emeroad added this to the 2.5.0 milestone Dec 21, 2022
@emeroad emeroad linked an issue Dec 21, 2022 that may be closed by this pull request
Copy link
Member

@emeroad emeroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emeroad emeroad merged commit 0eb0596 into pinpoint-apm:master Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linenumber
3 participants