Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleans up Hbase client plugin and IT #4805

Merged
merged 1 commit into from
Oct 29, 2018

Conversation

Xylus
Copy link
Contributor

@Xylus Xylus commented Oct 26, 2018

This removes reflection inside hbase plugin interceptor and replaces them with method dispatch.
Also fixes hbase plugin IT
related to #4367

@Xylus Xylus requested a review from emeroad October 26, 2018 06:08
@Xylus Xylus force-pushed the feature/issue-4367/hbase-plugin branch from 695847f to 6116c9a Compare October 26, 2018 06:41
@codecov-io
Copy link

Codecov Report

Merging #4805 into master will increase coverage by 0.01%.
The diff coverage is 13.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4805      +/-   ##
==========================================
+ Coverage   40.56%   40.58%   +0.01%     
==========================================
  Files        2589     2589              
  Lines       78774    78778       +4     
  Branches    10680    10682       +2     
==========================================
+ Hits        31958    31975      +17     
+ Misses      43897    43883      -14     
- Partials     2919     2920       +1
Impacted Files Coverage Δ
...hbase/interceptor/HbaseTableMethodInterceptor.java 44.11% <13.33%> (-5.89%) ⬇️
...corp/pinpoint/rpc/stream/StreamChannelManager.java 70.68% <0%> (-1.73%) ⬇️
...rc/main/java/com/navercorp/pinpoint/test/Item.java 68.96% <0%> (ø) ⬆️
...point/rpc/client/DefaultPinpointClientHandler.java 72.61% <0%> (+0.31%) ⬆️
...orp/pinpoint/rpc/server/DefaultPinpointServer.java 80.55% <0%> (+1.04%) ⬆️
...om/navercorp/pinpoint/rpc/codec/PacketDecoder.java 63.82% <0%> (+2.12%) ⬆️
...navercorp/pinpoint/rpc/common/SocketStateCode.java 85.36% <0%> (+2.43%) ⬆️
...ofiler/sender/StandbySpanStreamDataSendWorker.java 83.58% <0%> (+2.98%) ⬆️
...vercorp/pinpoint/rpc/packet/ClientClosePacket.java 66.66% <0%> (+11.11%) ⬆️
...rp/pinpoint/rpc/packet/ControlHandshakePacket.java 75.75% <0%> (+24.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caa438c...6116c9a. Read the comment docs.

@emeroad emeroad merged commit a844abb into pinpoint-apm:master Oct 29, 2018
@Xylus Xylus deleted the feature/issue-4367/hbase-plugin branch October 30, 2018 05:09
donghun-cho added a commit to donghun-cho/pinpoint that referenced this pull request May 18, 2022
donghun-cho added a commit to donghun-cho/pinpoint that referenced this pull request May 18, 2022
donghun-cho added a commit to donghun-cho/pinpoint that referenced this pull request May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants