Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elasticsearch Client Plugin Contribution #5595

Closed
wants to merge 7 commits into from

Conversation

yin-bp
Copy link
Contributor

@yin-bp yin-bp commented May 13, 2019

Title: Elasticsearch Client Plugin Contribution

Link: https://github.com/bbossgroups/pinpoint/tree/elasticsearch-567/plugins/elasticsearch-bboss
Target: Elasticsearch Rest Client BBoss
Supported Version: pinpoint 1.9.0
Description: This agent plugin is worked with elasticsearch rest client BBoss,BBoss is a best Java Highlevel Rest client for ElasticSearch.

ServiceTypes: [9201, "ElasticsearchBBoss"],[9202, "ElasticsearchBBossExecutor"]
Annotations: [971, "es.args"],[972, "es.url"],[973, "es.dsl"],[974, "es.action"],[975, "es.responseHandle"],[976, "es.version"]

Configurations: List of configuration keys and description the plugin adds.

profiler.elasticsearchbboss.enabled=true //enable or disable this plugin, default true.
profiler.elasticsearchbboss.recordResult=false //record or disable record method return value ,default false.
profiler.elasticsearchbboss.recordArgs=true //record or disable record method args,default true.
profiler.elasticsearchbboss.recordDsl=true //record or disable record dsl,default true.
profiler.elasticsearchbboss.recordESVersion=true //record or disable record ES Version infomation,default true.
profiler.elasticsearchbboss.recordResponseHandlerClass=false //record or disable record response handle class ,default false.
profiler.elasticsearchbboss.maxDslSize=50000 //set the max length dsl script,over this size dsl will be substring.

@codecov-io
Copy link

Codecov Report

Merging #5595 into master will decrease coverage by <.01%.
The diff coverage is 21.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5595      +/-   ##
==========================================
- Coverage   40.52%   40.52%   -0.01%     
==========================================
  Files        2865     2865              
  Lines       86454    86454              
  Branches    11444    11444              
==========================================
- Hits        35037    35033       -4     
- Misses      48381    48384       +3     
- Partials     3036     3037       +1
Impacted Files Coverage Δ
...ext/provider/grpc/AgentGrpcDataSenderProvider.java 0% <0%> (ø) ⬆️
...oint/profiler/sender/grpc/AgentGrpcDataSender.java 0% <0%> (ø) ⬆️
...om/navercorp/pinpoint/web/view/NodeSerializer.java 0% <0%> (ø) ⬆️
.../web/service/ResponseTimeHistogramServiceImpl.java 0% <0%> (ø) ⬆️
...t/collector/handler/grpc/GrpcSpanChunkHandler.java 16.66% <0%> (ø) ⬆️
...pender/histogram/DefaultNodeHistogramAppender.java 82.35% <100%> (ø) ⬆️
...map/appender/server/DefaultServerInfoAppender.java 88.57% <100%> (ø) ⬆️
...ppender/histogram/DefaultNodeHistogramFactory.java 59.72% <100%> (ø) ⬆️
...vercorp/pinpoint/rpc/packet/ServerClosePacket.java 52% <0%> (-16%) ⬇️
...vercorp/pinpoint/rpc/packet/ClientClosePacket.java 55.55% <0%> (-11.12%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d71e6e4...110979f. Read the comment docs.

@yin-bp yin-bp closed this May 13, 2019
@yin-bp yin-bp deleted the elasticsearch branch May 13, 2019 12:42
@yin-bp yin-bp restored the elasticsearch branch May 13, 2019 14:13
@yin-bp
Copy link
Contributor Author

yin-bp commented May 13, 2019

A new PR is #5596

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants