-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Elasticsearch Client bboss plugin #5596
Conversation
Hi,@RoySRose |
Codecov Report
@@ Coverage Diff @@
## master #5596 +/- ##
=========================================
- Coverage 40.51% 40.5% -0.02%
=========================================
Files 2865 2878 +13
Lines 86459 86783 +324
Branches 11444 11490 +46
=========================================
+ Hits 35031 35150 +119
- Misses 48390 48581 +191
- Partials 3038 3052 +14
Continue to review full report at Codecov.
|
Great Job.
|
@RoySRose : Here is a quickstart tutorial: All the Suggestions above have been adopted and the code has been submitted |
@RoySRose |
Does Elasticsearch-bboss support jdk6? |
Actually, there isn't any problem with the existing test code. I've merged PR #5596 to the master. I've modified I think it will be wise to version 5.x of elasticsearch rather than 6.3.0. Let me know when you're done |
@RoySRose |
Hello, @yin-bp Please check here https://blog.algolia.com/master-git-rebase/ this kindly explains about the rebase I was talking about. I use few tools such as sourcetree to easily manage git operations. |
- remove duplicate code
enhance grpc command
fix test
Adjust the reconnection interval to CommandStream
- remove server-map-for-transaction-list-container tag
add lightDumpService command
|
Title: Elasticsearch Client Plugin Contribution
Link: https://github.com/bbossgroups/pinpoint/tree/elasticsearch-plugin/plugins/elasticsearch-bboss
Target: Elasticsearch Rest Client BBoss
Supported Version: pinpoint 1.9.0
Description: This agent plugin is worked with elasticsearch rest client BBoss,BBoss is a best Java Highlevel Rest client for ElasticSearch.
ServiceTypes: [9201, "ElasticsearchBBoss"],[9202, "ElasticsearchBBossExecutor"]
Annotations: [971, "es.args"],[972, "es.url"],[973, "es.dsl"],[974, "es.action"],[975, "es.responseHandle"],[976, "es.version"]
Configurations: List of configuration keys and description the plugin adds.
profiler.elasticsearchbboss.enabled=true //enable or disable this plugin, default true.
profiler.elasticsearchbboss.recordResult=false //record or disable record method return value ,default false.
profiler.elasticsearchbboss.recordArgs=true //record or disable record method args,default true.
profiler.elasticsearchbboss.recordDsl=true //record or disable record dsl,default true.
profiler.elasticsearchbboss.recordESVersion=true //record or disable record ES Version infomation,default true.
profiler.elasticsearchbboss.recordResponseHandlerClass=false //record or disable record response handle class ,default false.
profiler.elasticsearchbboss.maxDslSize=50000 //set the max length dsl script,over this size dsl will be substring.