added vue-i18n package to pinry-spa with english support and locale changer to navigation bar #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's very nice of you to add i18n support to Pinry. |
winkidney
requested changes
Apr 15, 2022
winkidney
approved these changes
Apr 18, 2022
winkidney
requested changes
Apr 18, 2022
|
Thanks for your contribution again, and I have add my last change request Haha! |
winkidney
approved these changes
Apr 19, 2022
|
Will be merged, thanks again for your contribution : ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A request in issue 288 I saw there is a need for internationalization feature to allow international users of pinry to have the image boards translated into their language.
I have added a vue-i18n package to the pinry-spa to perform localization management. The main idea would be to extend the pinry-spa/src/assets/locales/en.json and additional json files for different languages.
Additionally I have added a example locale-changer that I have found on the intlify/vue-i18n-next documentation page. but please feel free to remove this and add in a better locale-changer dropdown.
https://vue-i18n.intlify.dev/guide/essentials/scope.html#global-scope-1
this is my first PR so if I have made any mistakes with the PR or changes please let me know.