Don/packet io - Update to cover library #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oadcast, unknown-unicast and unknown-multicast storm-control feature in SONiC
NPU to be replaced by ASIC/Multi-ASIC for consistency throughout the document [AI: Kartik/Arista] => document updated to use ASIC instead of NPU Section 1.2: Config & Management Requirements Rephrase second bullet to reflect port configuration is static i.e physical wiring only => Wording clarified as requqested Add context in the document for dynamic port changes [AI: Kartik/Arista] => Section outlining dynamic system port support added in "Future Work" section Section 2.3: State Sharing Update image separate Syncd, swss, DB container per fabric chip [AI: Kartik/Arista] => diagram updated to show multiple syncd, one per fabric chip Section 2.4: Chip Management Update section 2.4.2 to clarify switch ID numbering scheme in the system with reference from SAI specs. [AI: Kartik/Arista] => Section updated to reflect the correct numbering scheme with reference to the VOQ SAI spec. Section 2.5: Port Management Section 2.5.2 update system port table schema [AI: Kartik/Arista] => Updated to reflect proper instance naming as below Section 2.5.3 Update inband port to be explicitly provisioned [AI: Kartik/Arista] => wording around inband port is clarified. Require more clarity what is meant by instance - if LC has two ASICs then what will instance scope mean - swss/CPU instance? Is there is 1:1 mapping between instance to ASIC? [AI: Kartik/Arista] => Added new instance naming section describing naming scheme for both the FSI and an ASIC
Ifname must be unique per FSI. If we decide to create kernel devices for system ports, ifname may have to be globally unique. AI (Kartik/Arista): Amend wording in the document => amended wording in the document Any existing swss test can be run in the virtual chassis mode - except for LAG tests which aren’t compatible . AI (Kartik/Arista) - Clarify the conditions under which existing tests can be run unchanged. => clarified How would dual supervisor scenario work? What considerations do we have for two SSIs? (Danny/Microsoft) AI (Kartik/Arista) - add a summary in Future work section. => added a new dual supervisor section in Future work and summarized some high level approaches
- Clarifications on DB structure and naming - Cleaning up redundant sections that are expected to be covered in other docs
- Clarification of terminology - Renamed Chassis DB to Global DB - Revised the Global DB configuration structure - Added a failure handling section
per agreement in SONiC community
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Includes updates to address Microsoft's comments
bocon13
reviewed
Mar 31, 2022
stolsma
reviewed
Apr 1, 2022
doc/pins/Packet_io.md
Outdated
|
|
||
|
|
||
|
|
||
| ## Scope | ||
|
|
||
| This document covers the high level design aspects of Packet I/O in SONiC for P4Runtime application. | ||
| This document covers the high level design aspects of Packet I/O in SONiC for both the P4Runtime application and any subsequent application that would benifit from packet exchange using Generic Netlink Sockets. |
daniele-moro
reviewed
Apr 4, 2022
Co-authored-by: Daniele Moro <daniele.moro92@gmail.com>
Co-authored-by: Daniele Moro <daniele.moro92@gmail.com>
Updated the files for double braces error as suggested by [PR#942](docker/docs#942)
fix a broken link to an image
Co-authored-by: Brian O'Connor <bocon@opennetworking.org>
Co-authored-by: Daniele Moro <daniele.moro92@gmail.com>
Co-authored-by: Daniele Moro <daniele.moro92@gmail.com>
Co-authored-by: Daniele Moro <daniele.moro92@gmail.com>
Co-authored-by: Brian O'Connor <bocon@opennetworking.org>
Co-authored-by: Daniele Moro <daniele.moro92@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.