Add cancelAllOperations to PINOperationQueue #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettmoon
approved these changes
Oct 10, 2016
| - (void)cancelAllOperations | ||
| { | ||
| [self lock]; | ||
| for (PINOperation *operation in [_referenceToOperations objectEnumerator]) { |
There was a problem hiding this comment.
Another advantage of the _referenceToOperations weakTable :) We wouldn't have been able to enumerate over _queuedOperations without making a copy. Do you know if we need a copy here? Is it safe to enumerate over it even as objects are potentially being nil'd out by locked_cancelOperation?
There was a problem hiding this comment.
Seems like it's not safe to modify a mutable collection while enumerating through it via an NSEnumerator. So we probably have to make a copy.
There was a problem hiding this comment.
Seems like the right call to me.
| @@ -128,18 +128,33 @@ - (void)dealloc | |||
| return reference; | |||
| } | |||
|
|
|||
| - (void)cancelAllOperations | |||
| { | |||
| [self lock]; | |||
There was a problem hiding this comment.
nit: can you indent the code within the lock?
|
@garrettmoon Addressed comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to cancel all operations. Furthermore created a new method for cancelling an operation that the lock needs to be hold. This used by
cancelOperationas well ascancelAllOperationsnow.