Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Carthage for watchOS, fix macOS min deployment target version #269

Merged
merged 4 commits into from
Aug 20, 2020

Conversation

dreampiggy
Copy link
Contributor

@dreampiggy dreampiggy commented Apr 13, 2020

Dependent pinterest/PINOperation#31
This close #268

CC: @garrettmoon

To make Carthage works (because you use ~> 1.1.0 dependency):
You should firstly merge that PINOperation, release a new version.

Then merge this PR, release a new version.

Note: I also found that Carthage/Checkouts is not in Git Ignore files, does this have anything useful ? Why not ignore those files because when you run carthage update, it will be override and cause massive git diffs.

@dreampiggy
Copy link
Contributor Author

Local build success (I modify the Cartfile to point to my fork branch):

image

@garrettmoon
Copy link
Collaborator

@dreampiggy Thanks for putting this up! I'm going to merge and put up another PR to update Carthage to use PINOperation 1.2.

With regards to the checkins, I'm not 1000% convinced it's the best course of action, but the intention is to make it so the repo can be built as is without fetching dependencies.

@garrettmoon garrettmoon merged commit 2670c1d into pinterest:master Aug 20, 2020
@dreampiggy
Copy link
Contributor Author

Finally...This get merged :)

@dreampiggy dreampiggy deleted the carthage branch August 21, 2020 03:34
@garrettmoon
Copy link
Collaborator

Ah! I forgot the real reason we include checkouts is because the Xcode projects depend on them: #280

@dreampiggy
Copy link
Contributor Author

dreampiggy commented Aug 22, 2020

#280

You can just use add framework dependency using relative path. Then each user just need to run carthage update after cloning your repo, and open the Xcode project to build.

This is standard what package manager should do, like CocoaPods (You need to run pod update after clone the git repo...So your git repo size can under control).

@dreampiggy
Copy link
Contributor Author

@garrettmoon #279. Please check this to fix current watchOS Carthage issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PINCache's Carthage seems does not support watchOS
2 participants