PINCachedAnimatedImage: Fix retain cycles #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use NSNotificationCenter selector based observation. - Remove retain cycles when dispatching async to `PINOperation` and `dispatch_async` - Use internal methods since this code uses lots of ivars, which have implicity `self` references that are hard to find. - Add test that fails without this fix.
bolsinga
changed the title
bolsinga
requested review from
garrettmoon,
jparise,
rcancro,
rahul-malik and
woshimaliang
bolsinga
commented
Mar 10, 2020
woshimaliang
approved these changes
Mar 10, 2020
jparise
reviewed
Mar 10, 2020
jparise
reviewed
Mar 10, 2020
jparise
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PINOperationanddispatch_asyncselfreferences that are hard to find.