Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PINCachedAnimatedImage: Fix retain cycles #546

Merged
merged 4 commits into from
Mar 10, 2020
Merged

PINCachedAnimatedImage: Fix retain cycles #546

merged 4 commits into from
Mar 10, 2020

Commits on Mar 10, 2020

  1. PINCachedaAnimatedImage: Fix retain cycles 

    - Use NSNotificationCenter selector based observation.
- Remove retain cycles when dispatching async to `PINOperation` and `dispatch_async`
- Use internal methods since this code uses lots of ivars, which have implicity `self` references that are hard to find.
- Add test that fails without this fix.
    Greg Bolsinga committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    83ce982 View commit details
    Browse the repository at this point in the history

  2. wrap notification handling in PIN_TARGET_IOS

    Greg Bolsinga committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    2af8fed View commit details
    Browse the repository at this point in the history

  3. use PINWeakify/PINStrongify

    Greg Bolsinga committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    eebd2a4 View commit details
    Browse the repository at this point in the history

  4. forget to test compilation. sigh.

    Greg Bolsinga committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    92cbaa9 View commit details
    Browse the repository at this point in the history