Internal: add Cypress integration tests #1220
Conversation
|
Deploy preview for gestalt ready! Built with commit da806d1 |
|
Deploy preview for gestalt ready! Built with commit 71724fe |
christianvuerings
force-pushed
the
cypress-github
branch
from
f56e491
to
977b1c5
Compare
christianvuerings
force-pushed
the
cypress-github
branch
from
977b1c5
to
71724fe
Compare
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "baseUrl": "http://localhost:3000", | |||
| "projectId": "x99ctf", | |||
There was a problem hiding this comment.
See https://dashboard.cypress.io/projects/x99ctf - plan to add this link to our docs once this is merged
| @@ -16,7 +16,7 @@ card( | |||
| <Link inline target="blank" href="https://npmjs.org/package/gestalt"> | |||
| <img | |||
| src="https://img.shields.io/npm/v/gestalt.svg?label=gestalt" | |||
| alt="Gestalt's NPM package version badge" | |||
| alt="Gestalt NPM package version badge" | |||
There was a problem hiding this comment.
A11Y fix - axe-core picked up that we had the same descriptions for these links
| mdPadding={6} | ||
| lgPadding={8} | ||
| width="100%" | ||
| role="main" |
There was a problem hiding this comment.
A11Y fix - we need to add role to all places that have content on the page
| <Link | ||
| href={`#${slugifiedId}`} | ||
| inline | ||
| accessibilityLabel={`${name} - Anchor tag`} |
There was a problem hiding this comment.
A11Y fix: used to be an empty link without a good label
| @@ -1,5 +1,5 @@ | |||
| .Markdown pre { | |||
| background-color: rgb(236, 236, 236); | |||
| background-color: rgba(236, 236, 236, 0.5); | |||
There was a problem hiding this comment.
A11Y fix - detected that the contrast wasn't high enough (WCAG 2.0 AA)
| @@ -10,8 +10,8 @@ export default function SidebarSection({ | |||
| section: sidebarIndexType, | |||
| |}): Node { | |||
| return ( | |||
| <> | |||
| <Box padding={2} marginTop={4} role="list"> | |||
| <Box role="list"> | |||
There was a problem hiding this comment.
A11Y Fix: we previous had a <Box role="list" /> without any role="listitem" in them.
| @@ -50,20 +53,20 @@ | |||
| "lint-staged": "^10.3.0", | |||
| "netlify-cli": "^2.61.2", | |||
| "papaparse": "^5.3.0", | |||
| "postcss": "^7.0.32", | |||
There was a problem hiding this comment.
alphabetized these (happened when I added cypress as a dev package)
Instead of Netlify CLI, use GitHub actions to run cypress integration tests.
Test Plan
Next steps
Notes