Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: persist dark mode and RTL settings across refreshes #1272

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Docs: persist dark mode and RTL settings across refreshes #1272

merged 1 commit into from
Oct 28, 2020

Conversation

christianvuerings
Copy link
Contributor

Changes

  • Persist dark mode and RTL settings across refreshes (using local storage)
  • Introduces useLocalStorage to make it easier to work with local storage in our docs. Forked from https://usehooks.com/useLocalStorage/

Test Plan

  1. Go to /
  2. Switch to dark mode
  3. Reload

Expected result: dark mode is still enabled.

@christianvuerings christianvuerings added the patch release Patch release label Oct 27, 2020
@christianvuerings christianvuerings requested a review from a team as a code owner October 27, 2020 18:27
@netlify
Copy link

netlify bot commented Oct 27, 2020

Deploy preview for gestalt ready!

Built with commit b35b22f

https://deploy-preview-1272--gestalt.netlify.app

ayeshakmaz
ayeshakmaz approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@ayeshakmaz ayeshakmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great 👍

@christianvuerings christianvuerings merged commit 224c3a6 into pinterest:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayeshakmaz ayeshakmaz ayeshakmaz approved these changes

@AlbertCarreras AlbertCarreras Awaiting requested review from AlbertCarreras

Assignees
No one assigned
Labels
patch release Patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christianvuerings @ayeshakmaz