TextArea: Add support for Tags #1315
Conversation
|
✔️ Deploy preview for gestalt ready! 🔨 Explore the source changes: dd9dcd8 🔍 Inspect the deploy logs: https://app.netlify.com/sites/gestalt/deploys/5fdbc1dbb4403e000897c85d 😎 Browse the preview: https://deploy-preview-1315--gestalt.netlify.app |
|
✔️ Deploy preview for gestalt ready! 🔨 Explore the source changes: 05d9da6 🔍 Inspect the deploy logs: https://app.netlify.com/sites/gestalt/deploys/5ff8a6900586b900078c3b24 😎 Browse the preview: https://deploy-preview-1315--gestalt.netlify.app |
packages/gestalt/src/TextArea.css
Outdated
| .unstyledTextArea { | ||
| composes: absolute left0 top0 right0 bottom0 from "./Layout.css"; | ||
| height: 100%; | ||
| padding: 6px 8px; |
There was a problem hiding this comment.
We're actually in the process of making Spacing tokens, so in the meantime we should probably stick to our "boint" system (4px = 1 boint), like so:
padding: calc(var(--g-boint) * 4)
Also, 6px will not be part of the new system, can this go up to 8 or down to 4?
There was a problem hiding this comment.
The 6px are there to align the text with the tags. I can't really do any centering hackery because the <textarea> needs to have a 100% height. This is what it would look like with 4px:
I can change it if @ashleyseto is ok with it
There was a problem hiding this comment.
I think the issue right now is the text in the input is larger than the text in the tags. Is that correct? I'm not really sure how to resolve this right now. If we want to keep to 4px for now to not add odd spaces, we can. I think most of my spacing comments were around the internal part of the tag so that doesn't look weird.
Same as #1306 but for TextArea
Tag component
Doc
Figma
Test Plan
(the weird scrollbar overflow issue is unrelated to these changes, and I couldn't find a quick fix)