-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Prototype] Module changes #1329
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
624dd5f
added external control
galaxy0101 1008794
added description
galaxy0101 22d1b8f
removed the example5 as requested
galaxy0101 0531073
fixed nits
galaxy0101 ae524e8
modified description
galaxy0101 d3bb9f0
Prototype
AlbertCarreras File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
// @flow strict | ||
import React, { useState, type Node } from 'react'; | ||
import React, { useState, useEffect, type Node } from 'react'; | ||
import Box from './Box.js'; | ||
import Divider from './Divider.js'; | ||
import ModuleExpandableBase from './ModuleExpandableBase.js'; | ||
|
@@ -9,6 +9,7 @@ type Props = {| | |
id: string, | ||
accessibilityExpandLabel: string, | ||
accessibilityCollapseLabel: string, | ||
expandedIdx?: ?number, | ||
items: $ReadOnlyArray<{| | ||
title: string, | ||
icon?: $Keys<typeof icons>, | ||
|
@@ -23,9 +24,18 @@ export default function ModuleExpandable({ | |
id, | ||
accessibilityExpandLabel, | ||
accessibilityCollapseLabel, | ||
expandedIdx, | ||
items, | ||
}: Props): Node { | ||
const [expandedId, setExpandedId] = useState(-1); | ||
const [localExpandedId, setLocalExpandedId] = useState( | ||
expandedIdx ? `${id}-${expandedIdx}` : null | ||
); | ||
|
||
useEffect(() => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. main change |
||
setLocalExpandedId( | ||
expandedIdx || expandedIdx === 0 ? `${id}-${expandedIdx}` : null | ||
); | ||
}, [id, expandedIdx, setLocalExpandedId]); | ||
|
||
return ( | ||
<Box rounding={2} borderStyle="shadow"> | ||
|
@@ -42,13 +52,13 @@ export default function ModuleExpandable({ | |
icon={icon} | ||
iconAccessibilityLabel={iconAccessibilityLabel} | ||
summary={summary} | ||
isCollapsed={expandedId !== index} | ||
isCollapsed={localExpandedId !== `${id}-${index}`} | ||
type={type} | ||
accessibilityExpandLabel={accessibilityExpandLabel} | ||
accessibilityCollapseLabel={accessibilityCollapseLabel} | ||
onModuleClicked={(isExpanded) => | ||
setExpandedId(isExpanded ? -1 : index) | ||
} | ||
onModuleClicked={(isExpanded) => { | ||
setLocalExpandedId(isExpanded ? null : `${id}-${index}`); | ||
}} | ||
> | ||
{children} | ||
</ModuleExpandableBase> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
main change