Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColorSchemeProvider, OnLinkNavigationProvider: split Provider into individual providers #1534

Merged
merged 2 commits into from
Jun 3, 2021
Merged

ColorSchemeProvider, OnLinkNavigationProvider: split Provider into individual providers #1534

merged 2 commits into from
Jun 3, 2021

Conversation

AlbertCarreras
Copy link
Contributor

@AlbertCarreras AlbertCarreras commented Jun 3, 2021 •
edited
Loading

Splitting Provider into ColorSchemeProvider, OnLinkNavigationProvider

Problem:

  • Nesting providers within Provider made providers conflict with each other.
  • Pages with onNavigation and no colorScheme were overriding parent providers with colorScheme.

Improvements

  • Separation of concerns
  • More explicit naming for Providers re their usage/purpose

Caveats

  • More Gestalt providers mean more provider trees within the application adding to an already existing large amount of existing providers. A GestaltProvider can be created outside of Gestalt, within the app to facilitate readability and logic grouping.

Description

Links

Checklist

  • Added Unit and Flow Tests
  • Added documentation + accessibility tests
  • Verified Accessibility: keyboard & screen reader interaction
  • Checked Dark Mode, Responsiveness, and Right-to-Left support
  • Checked Stakeholder feedback (ex. Gestalt designers)

@AlbertCarreras AlbertCarreras added the major release Major release label Jun 3, 2021
@netlify
Copy link

netlify bot commented Jun 3, 2021 •
edited
Loading

✔️ Deploy Preview for gestalt ready!

🔨 Explore the source changes: 1d1d00d

🔍 Inspect the deploy log: https://app.netlify.com/sites/gestalt/deploys/60b9363dbf8afd0007c26067

😎 Browse the preview: https://deploy-preview-1534--gestalt.netlify.app/

@AlbertCarreras AlbertCarreras force-pushed the Provoders branch 4 times, most recently from fa9547e to aed123b Compare June 3, 2021 17:39
@AlbertCarreras AlbertCarreras marked this pull request as ready for review June 3, 2021 17:40
@AlbertCarreras AlbertCarreras requested a review from a team as a code owner June 3, 2021 17:40
@AlbertCarreras AlbertCarreras changed the title ColorSchemeProvider, OnLinkNavigationProvider: split Provider into individual providers [WIP] ColorSchemeProvider, OnLinkNavigationProvider: split Provider into individual providers Jun 3, 2021
@AlbertCarreras AlbertCarreras changed the title [WIP] ColorSchemeProvider, OnLinkNavigationProvider: split Provider into individual providers ColorSchemeProvider, OnLinkNavigationProvider: split Provider into individual providers Jun 3, 2021
@AlbertCarreras AlbertCarreras force-pushed the Provoders branch 3 times, most recently from eaf45c5 to 36e4774 Compare June 3, 2021 20:05
@AlbertCarreras AlbertCarreras merged commit bee0a9c into pinterest:master Jun 3, 2021
@AlbertCarreras AlbertCarreras deleted the Provoders branch September 20, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dangerismycat dangerismycat dangerismycat approved these changes

Assignees
No one assigned
Labels
major release Major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlbertCarreras @dangerismycat