Create custom width property for flyout #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @JediMasterRemington - this looks good. However, I think having both a <Flyout size="sm" width={800} ... />Could you perhaps merge both properties together so that |
|
I've made it so size can now take a number |
chrislloyd
reviewed
Feb 20, 2018
src/Flyout/Flyout.js
Outdated
| @@ -52,5 +52,5 @@ Flyout.propTypes = { | |||
| idealDirection: PropTypes.oneOf(['up', 'right', 'down', 'left']), | |||
| onDismiss: PropTypes.func.isRequired, | |||
| positionRelativeToAnchor: PropTypes.bool, | |||
| size: PropTypes.oneOf(['xs', 'sm', 'md', 'lg', 'xl']), // default: sm | |||
| size: PropTypes.oneOf(['xs', 'sm', 'md', 'lg', 'xl', PropTypes.number]), // default: sm | |||
There was a problem hiding this comment.
I don't think this will do what you want it to. It's looking for the exact usage of PropTypes.number rather than
PropTypes.oneOfType(PropTypes.number, PropTypes.oneOf([ ... ]))
chrislloyd
approved these changes
Feb 20, 2018
chrislloyd
approved these changes
Feb 20, 2018
This was referenced Feb 22, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes design specifications could require the Flyout to extend pass the five standardized sizes. Because the flyout has no method for extending beyond the size, this PR adds a width property to the Flyout component in order to allow the flyout to have custom sizes for when the Flyout must be a different size other than the standardized sizes.
Pros
Cons