Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add logo!! #1813

Merged
merged 3 commits into from
Dec 14, 2021
Merged

Docs: add logo!! #1813

merged 3 commits into from
Dec 14, 2021

Conversation

dangerismycat
Copy link
Contributor

@dangerismycat dangerismycat commented Dec 13, 2021

Also moves Pinterest logo to footer, makes header light gray, makes all header buttons/text dark gray

Light mode
Screen Shot 2021-12-13 at 1 00 41 PM
Screen Shot 2021-12-13 at 1 00 50 PM

Dark mode
Screen Shot 2021-12-13 at 1 01 04 PM
Screen Shot 2021-12-13 at 1 01 11 PM

Small screens
Screen Shot 2021-12-13 at 1 00 15 PM
Screen Shot 2021-12-13 at 1 00 24 PM

Also moves Pinterest logo to footer, makes header light gray, makes all header buttons/text dark gray
@dangerismycat dangerismycat added the patch release Patch release label Dec 13, 2021
@netlify
Copy link

netlify bot commented Dec 13, 2021

✔️ Deploy Preview for gestalt ready!

🔨 Explore the source changes: 35e04f2

🔍 Inspect the deploy log: https://app.netlify.com/sites/gestalt/deploys/61b7f67c9b174700076ce5f2

😎 Browse the preview: https://deploy-preview-1813--gestalt.netlify.app

@dangerismycat dangerismycat marked this pull request as ready for review December 14, 2021 00:13
@dangerismycat dangerismycat requested a review from a team as a code owner December 14, 2021 00:13
@ponori
Copy link
Contributor

ponori commented Dec 14, 2021

LGTM! I'll let @AlbertCarreras and/or @ayeshakmaz chime in from a code standpoint.

Copy link
Contributor

@ayeshakmaz ayeshakmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the 500 image get used?

@dangerismycat
Copy link
Contributor Author

Does the 500 image get used?

Not currently, no. I just figured it'd get used in the future and I added it now so I don't have to track it down in the future. It's a little YAGNI but I figure it doesn't really matter…happy to remove if anyone feels strongly about it though.

Copy link
Contributor

@ayeshakmaz ayeshakmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Very exciting!!

@dangerismycat dangerismycat merged commit 94be71e into pinterest:master Dec 14, 2021
@dangerismycat dangerismycat deleted the docs-logo branch December 14, 2021 18:42
import DocSearch from './DocSearch.js';
import HeaderMenu from './HeaderMenu.js';
import Link from './Link.js';
import trackButtonClick from './buttons/trackButtonClick.js';
import { useNavigationContext } from './navigationContext.js';
import gestaltLogo from '../public/gestalt-logo-250.png';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dangerismycat could we use an inline SVG instead (Just like we do with our icons)? It would result in:

  • Avoiding blurriness when zooming in:
    image

  • No longer flash the logo on load:
    logo-flash-on-load

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, will take care of that in a follow-up PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch release Patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants