-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: add logo!! #1813
Docs: add logo!! #1813
Conversation
Also moves Pinterest logo to footer, makes header light gray, makes all header buttons/text dark gray
✔️ Deploy Preview for gestalt ready! 🔨 Explore the source changes: 35e04f2 🔍 Inspect the deploy log: https://app.netlify.com/sites/gestalt/deploys/61b7f67c9b174700076ce5f2 😎 Browse the preview: https://deploy-preview-1813--gestalt.netlify.app |
LGTM! I'll let @AlbertCarreras and/or @ayeshakmaz chime in from a code standpoint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the 500 image get used?
Not currently, no. I just figured it'd get used in the future and I added it now so I don't have to track it down in the future. It's a little YAGNI but I figure it doesn't really matter…happy to remove if anyone feels strongly about it though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Very exciting!!
import DocSearch from './DocSearch.js'; | ||
import HeaderMenu from './HeaderMenu.js'; | ||
import Link from './Link.js'; | ||
import trackButtonClick from './buttons/trackButtonClick.js'; | ||
import { useNavigationContext } from './navigationContext.js'; | ||
import gestaltLogo from '../public/gestalt-logo-250.png'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dangerismycat could we use an inline SVG instead (Just like we do with our icons)? It would result in:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, will take care of that in a follow-up PR
Also moves Pinterest logo to footer, makes header light gray, makes all header buttons/text dark gray
Light mode
Dark mode
Small screens