Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update navigation and badge colors #1984

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

ayeshakmaz
Copy link
Contributor

@ayeshakmaz ayeshakmaz commented Mar 14, 2022

Summary

What changed?

Now that we have updated Text colors that work in dark mode, I updated the TOC green to use the new color, and updated the required badges to use "warning"

Why?

With recently color updates that better support dark mode, this enhances our docs in dark mode

Before

Screen Shot 2022-03-15 at 1 31 43 AM

Screen Shot 2022-03-15 at 1 32 08 AM

After

Screen Shot 2022-03-15 at 1 30 48 AM

Screen Shot 2022-03-15 at 1 31 23 AM

Before

Screen Shot 2022-03-15 at 1 39 49 AM

After

Screen Shot 2022-03-15 at 1 41 04 AM

@ayeshakmaz ayeshakmaz requested a review from a team as a code owner March 14, 2022 21:36
@ayeshakmaz ayeshakmaz added the patch release Patch release label Mar 14, 2022
@netlify
Copy link

netlify bot commented Mar 14, 2022

✔️ Deploy Preview for gestalt ready!

🔨 Explore the source changes: e1bd58c

🔍 Inspect the deploy log: https://app.netlify.com/sites/gestalt/deploys/622fb542d234d90008a5f088

😎 Browse the preview: https://deploy-preview-1984--gestalt.netlify.app

Copy link
Contributor

@AlbertCarreras AlbertCarreras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayeshakmaz ayeshakmaz merged commit 424ddf8 into pinterest:master Mar 15, 2022
@ayeshakmaz ayeshakmaz deleted the ayesha/docs-color-updates branch March 15, 2022 00:45
@dangerismycat
Copy link
Contributor

Late hit from me, but that yellow is totally 👍 to me, doesn't seem too aggressive or anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch release Patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants