Tooltip: minor refactor #2105
Merged
Tooltip: minor refactor #2105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbertCarreras
commented
May 6, 2022
| @@ -213,51 +213,48 @@ class Contents extends Component<Props, State> { | |||
|
|
|||
| return ( | |||
| <div | |||
| className={styles.container} | |||
There was a problem hiding this comment.
Merge this and the following div into 1
✅ Deploy Preview for gestalt ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
AlbertCarreras
commented
May 9, 2022
| @@ -121,48 +121,49 @@ function ScrollBoundaryContainerExample() { | |||
| idealDirection="right" | |||
| text="See stats about different types of content created by you and/or others on Pinterest. Filter to get more details on your organic (not an ad) and paid (promoted as an ad) content." | |||
| > | |||
| <Icon | |||
There was a problem hiding this comment.
Example better a11y
dangerismycat
approved these changes
May 9, 2022
| /> | ||
| </Box> | ||
| </Box> | ||
| <Flex direction="column"> |
There was a problem hiding this comment.
looks like the left side is getting cut off a bit
There was a problem hiding this comment.
Cant repro this
| </Box> | ||
| <Flex direction="column"> | ||
| <Fieldset legend="Select content type" legendDisplay="hidden"> | ||
| <Box paddingY={1}> |
There was a problem hiding this comment.
should this use Flex and gap, or does that not work well with Fieldset?
There was a problem hiding this comment.
DONE. good catch
AlbertCarreras
force-pushed
the
PopoverFix
branch
from
6282659
to
d3bdf63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What changed?
Tooltip: minor refactor