Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and remove ErrorFlyout from Gestalt #251

Merged
merged 6 commits into from
Jun 13, 2018

Conversation

pfarejowicz
Copy link
Contributor

Now that we have a release that allows clients to create an ErrorFlyout-like component via the Flyout props, we can fully deprecate and remove the ErrorFlyout component in the next release. This change removes all references to that component and removes it from the export.

Snapshots did not change which is a good sign that nothing visually changes in the UI with this switch 👍

@christianvuerings
Copy link
Contributor

christianvuerings commented Jun 9, 2018

Deploy preview for gestalt ready!

Built with commit 559d882

https://deploy-preview-251--gestalt.netlify.com

@codecov-io
Copy link

codecov-io commented Jun 9, 2018

Codecov Report

Merging #251 into master will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #251      +/-   ##
==========================================
- Coverage   70.73%   70.55%   -0.18%     
==========================================
  Files          46       45       -1     
  Lines         820      815       -5     
  Branches      189      188       -1     
==========================================
- Hits          580      575       -5     
  Misses        169      169              
  Partials       71       71
Impacted Files Coverage Δ
packages/gestalt/src/TextField/TextField.js 42.1% <ø> (ø) ⬆️
packages/gestalt/src/TextArea/TextArea.js 35% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92986a3...559d882. Read the comment docs.

@ghost
Copy link

ghost commented Jun 13, 2018

Filename Size Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip
gestalt.js 🔻 0.1% 🔻 0.1% 268.36 KB 268.08 KB 59.54 KB 59.46 KB
gestalt.es.js 🔻 0.1% 🔻 0.1% 265.73 KB 265.44 KB 59.18 KB 59.1 KB

Generated by 🚫 dangerJS

@pfarejowicz pfarejowicz merged commit 9c9eaa7 into pinterest:master Jun 13, 2018
@pfarejowicz pfarejowicz deleted the deprecate_errorflyout branch June 13, 2018 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants