Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: update flow-typed definitions #873

Conversation

christianvuerings
Copy link
Contributor

Updates Gestalt's flow-typed definitions - got this output by running flow-typed install in ~/code/gestalt/

@christianvuerings christianvuerings requested a review from a team as a code owner May 19, 2020 15:03
@christianvuerings christianvuerings added the patch release Patch release label May 19, 2020
@@ -17,7 +17,7 @@ test('Checkbox handles click', () => {
/>
</form>
);
getByLabelText('Label').click({ currentTarget: { checked: true } });
getByLabelText('Label').click();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

click does not take any arguments

target: { value: 'panda' },
});
expect(mockChange).toHaveBeenCalled();
const textarea = container.querySelector('textarea');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

container.querySelector can return null

@christianvuerings christianvuerings merged commit 4a14da5 into pinterest:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch release Patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant