Fix statement-wrapping and align rule classes #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d by the StandardRuleSetProvider of ktlint `0.50` and as of that is not run by Ktlint CLI
3flex
added a commit
to detekt/detekt
that referenced
this pull request
Sep 6, 2023
3flex
added a commit
to detekt/detekt
that referenced
this pull request
Sep 17, 2023
3flex
added a commit
to detekt/detekt
that referenced
this pull request
Oct 5, 2023
3flex
added a commit
to detekt/detekt
that referenced
this pull request
Oct 8, 2023
3flex
added a commit
to detekt/detekt
that referenced
this pull request
Oct 13, 2023
3flex
added a commit
to detekt/detekt
that referenced
this pull request
Oct 13, 2023
3flex
added a commit
to detekt/detekt
that referenced
this pull request
Nov 1, 2023
3flex
added a commit
to detekt/detekt
that referenced
this pull request
Nov 1, 2023
…6468) * Update dependency com.pinterest.ktlint:ktlint-ruleset-standard to v1 * Update dependency com.pinterest.ktlint:ktlint-ruleset-standard to v1.0.1 * Update imports for renamed ktlint classes See pinterest/ktlint#2178 * Add new ktlint rules added in v1.0 * ChainMethodContinuation * ClassSignature * FunctionExpressionBody * FunctionLiteral * FunctionTypeModifierSpacing * Fix packaging kotlin-logging group changed from io.github.microutils to io.github.oshai. From v5 it does not depend on slf4j-api. ktlint-logger doesn't depend on slf4j-api either so we need to include it as a runtime dependency now. * Enable formerly experimental rules by default These were promoted to running by default in pinterest/ktlint#2218 * Remove redundant declarations from detekt's detekt config * Disable formatting rules that have many violations * Fix remaining ktlint issues * Fix ktlint doc link in NoEmptyFirstLineInClassBody Co-authored-by: marschwar <marschwar@users.noreply.github.com> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Matthew Haughton <3flex@users.noreply.github.com> Co-authored-by: marschwar <marschwar@users.noreply.github.com>
mgroth0
pushed a commit
to mgroth0/detekt
that referenced
this pull request
Feb 11, 2024
…etekt#6468) * Update dependency com.pinterest.ktlint:ktlint-ruleset-standard to v1 * Update dependency com.pinterest.ktlint:ktlint-ruleset-standard to v1.0.1 * Update imports for renamed ktlint classes See pinterest/ktlint#2178 * Add new ktlint rules added in v1.0 * ChainMethodContinuation * ClassSignature * FunctionExpressionBody * FunctionLiteral * FunctionTypeModifierSpacing * Fix packaging kotlin-logging group changed from io.github.microutils to io.github.oshai. From v5 it does not depend on slf4j-api. ktlint-logger doesn't depend on slf4j-api either so we need to include it as a runtime dependency now. * Enable formerly experimental rules by default These were promoted to running by default in pinterest/ktlint#2218 * Remove redundant declarations from detekt's detekt config * Disable formatting rules that have many violations * Fix remaining ktlint issues * Fix ktlint doc link in NoEmptyFirstLineInClassBody Co-authored-by: marschwar <marschwar@users.noreply.github.com> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Matthew Haughton <3flex@users.noreply.github.com> Co-authored-by: marschwar <marschwar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add rule
statement-wrappingto theStandardRuleSetProviderCloses #2170
Align names of Rule classes, file and
RULE_IDconstantsCloses #2176
Do not wrap a single line enum class
Closes #2177
Checklist
Before submitting the PR, please check following (checks which are not relevant may be ignored):
Closes #<xxx>orFixes #<xxx>(replace<xxx>with issue number)CHANGELOG.mdis updatedDocumentation is updated. See difference between snapshot and release documentation