Replace editorconfig parser to ec4j. #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add dependency to maven config in 970860c |
Tapchicoma
force-pushed
the
fix-editorconfig-parsing
branch
2 times, most recently
from
79c207d
to
970860c
Compare
Replaced custom parser, that is hard to maintain and not working well, with https://github.com/ec4j/ec4j parser. Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>
Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>
Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>
|
looks good. thanks for adding the extra tests as well. |
sowmyav24
pushed a commit
to sowmyav24/ktlint
that referenced
this pull request
Aug 31, 2019
* Change editorconfig parser. Replaced custom parser, that is hard to maintain and not working well, with https://github.com/ec4j/ec4j parser. Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com> * Trim whitespaces in parsed disabled rules values. Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com> * Add ec4j dependency to maven. Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>
sowmyav24
pushed a commit
to sowmyav24/ktlint
that referenced
this pull request
Aug 31, 2019
* Change editorconfig parser. Replaced custom parser, that is hard to maintain and not working well, with https://github.com/ec4j/ec4j parser. Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com> * Trim whitespaces in parsed disabled rules values. Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com> * Add ec4j dependency to maven. Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>
sowmyav24
pushed a commit
to sowmyav24/ktlint
that referenced
this pull request
Sep 3, 2019
* Change editorconfig parser. Replaced custom parser, that is hard to maintain and not working well, with https://github.com/ec4j/ec4j parser. Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com> * Trim whitespaces in parsed disabled rules values. Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com> * Add ec4j dependency to maven. Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace custom editorconfig parser to https://github.com/ec4j/ec4j.
It is one of official java
.editorconfigparsers: https://editorconfig.org/#create-a-pluginFixes #555