Add spacing rule for UnaryExpression #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just noticed that already a pull request for unary op has been merged ： #428 But I can not find any related files in master branch. Is there something wrong? |
|
It was reverted in this commit: a08dfd1 |
Tapchicoma
reviewed
Jun 26, 2020
ktlint-ruleset-standard/src/test/resources/spec/unary-op-spacing/format.kt.spec
Outdated
Show resolved
Hide resolved
|
Suddenly thought of a case. var i = - /*abc*/ 1 // it this should be valid?
i = -/*abc*/1 // or it this should be validI try to format this in IDEA, neither line of code is formatted.. |
|
I wonder who writes such code with inlined comments 😅 IMHO, second case should be proper one. |
romtsn
suggested changes
Jun 27, 2020
...andard/src/main/kotlin/com/pinterest/ktlint/ruleset/standard/SpacingInUnaryExpressionRule.kt
Outdated
Show resolved
Hide resolved
...andard/src/main/kotlin/com/pinterest/ktlint/ruleset/standard/SpacingInUnaryExpressionRule.kt
Outdated
Show resolved
Hide resolved
romtsn
suggested changes
Jun 30, 2020
...et-standard/src/main/kotlin/com/pinterest/ktlint/ruleset/standard/StandardRuleSetProvider.kt
Outdated
Show resolved
Hide resolved
...andard/src/main/kotlin/com/pinterest/ktlint/ruleset/standard/SpacingInUnaryExpressionRule.kt
Outdated
Show resolved
Hide resolved
romtsn
approved these changes
Jun 30, 2020
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a rule to check spacing in
KtUnaryExpression.Example: