Only import the necessary set of types #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicoYao
approved these changes
Aug 23, 2019
We were previously importing the java.util.{Date,List,Map,Set} types
unconditionally. We now detect which types are needed based on walking
the schema and only emitting imports for the types that are actually
used.
jparise
force-pushed
the
java-type-imports
branch
from
ada43e7
to
4eeab07
Compare
rahul-malik
approved these changes
Aug 23, 2019
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously importing the
java.util.{Date,List,Map,Set}typesunconditionally. We now detect which types are needed based on walking
the schema and only emitting imports for the types that are actually
used.