Don't camel case the description for EnumValue by default #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maicki - Can we write some small tests around this and also regenerate the integration test snapshots? |
|
@rahul-malik The integration test snapshots are already regenerated, there are no differences (as it should be), I will work on adding tests around this. |
maicki
commented
Jun 16, 2017
| XCTAssert("created_at".snakeCaseToPropertyName() == "createdAt") | ||
|
|
||
| // (@maicki): This test would currently fail as the result is "CreatedAt". | ||
| // XCTAssert("CreatedAt".snakeCaseToPropertyName() == "createdAt") |
There was a problem hiding this comment.
This test would currently fail, @rahul-malik what do you think should be the right output for snakeCaseToPropertyName in this case?
There was a problem hiding this comment.
I think what you have here is the desired output. I'm assuming we generate createdat right now?
|
@rahul-malik Added a couple of tests for |
|
🚫 CI failed with log |
Generated by 🚫 Danger |
rahul-malik
approved these changes
Jun 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description for an EnumValue is always in camel case. This should be the responsibility of the consumer to change between different cases and not assumed that camel case is expected every time.
One example is within the integer enum case of #57. We would like to add a comment with the description, currently by default this is in camel case although it's defined in snake case and wanted in snake case.