Added support for NSSet properties #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚫 CI failed with log |
|
🚫 CI failed with log |
rahul-malik
suggested changes
Oct 25, 2017
| @@ -100,6 +102,15 @@ - (instancetype)initWithModelDictionary:(NS_VALID_UNTIL_END_OF_SCOPE NSDictionar | |||
| } | |||
| } | |||
| { | |||
| __unsafe_unretained id value = modelDictionary[@"contributors"]; // Collection will retain. | |||
There was a problem hiding this comment.
Doesn't this need to be converted to NSSet?
There was a problem hiding this comment.
Good catch. I just added it.
| NSMutableSet *result0 = [NSMutableSet setWithCapacity:items0.count]; | ||
| for (id obj0 in items0) { | ||
| if (obj0 != (id)kCFNull) { | ||
| [result0 addObject:[obj0 dictionaryRepresentation]]; |
There was a problem hiding this comment.
I think we're going to have to add a cast here to avoid hitting warnings for strict selector matching. Added an issue here #90
| +counts: ?{ +[string]: number } /* Integer */, | ||
| +created_at: ?PlankDate, | ||
| +contributors: ?Set<UserType>, |
There was a problem hiding this comment.
@maicki - Can you sign off on the flow changes?
maicki
reviewed
Oct 25, 2017
|
|
||
| export type BoardType = $Shape<{| | ||
| +name: ?string, | ||
| +id: ?string, | ||
| +image: ?ImageType, | ||
| +image: ImageType, |
There was a problem hiding this comment.
Why did this change? Seems not related to this change though.
There was a problem hiding this comment.
@maicki I don't know exactly. This was all generated code.
rahul-malik
approved these changes
Nov 2, 2017
Generated by 🚫 Danger |
|
@rahul-malik LGTM merge whenever |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking #70 as inspiration for how to spec it, this PR takes into consideration the
uniquekey that can be defined forarrayproperties. Is set, instead of creating aNSArray, it will create aNSSetinstead.Example: