Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support zookeeper chroots #2

Closed
sclasen opened this issue May 2, 2014 · 5 comments
Closed

support zookeeper chroots #2

sclasen opened this issue May 2, 2014 · 5 comments

Comments

@sclasen
Copy link

sclasen commented May 2, 2014

secor currently assumes kafka is pointed at the root zk node
@pgarbacki
Copy link
Contributor

Correct. I'm planning to upgrade Secor to kafka 0.81 that has an API for updating consumer offsets. Consequently, Secor won't be directly modifying zk's nodes.

@sclasen
Copy link
Author

sclasen commented May 2, 2014

cool, would also be good to configure the /secor/locks path prefix

@pgarbacki
Copy link
Contributor

Good point.

yswu pushed a commit to yswu/secor that referenced this issue Nov 21, 2014
@pgarbacki
Merge pull request pinterest#2 from pawel/adhoc
ff9bc91 
Minor updates to the design doc
@memelet
Copy link

memelet commented Dec 2, 2015

What was the result for this? Can the chroot be specified somehow? For example we configure the broker to use /kafka. I don't see how to configure that other than append to the zookeeper.quarum.

But looking at

secor/src/main/java/com/pinterest/secor/common/ZookeeperConnector.java

Line 61 in 0d58060

private Iterable<InetSocketAddress> getZookeeperAddresses() {
it seems that that won't work.

@memelet
Copy link

memelet commented Dec 2, 2015

Ok, sorry. I see its available in config/secor.common.properties.

HenryCaiHaiying pushed a commit that referenced this issue Oct 24, 2016
@ahsandar
Merge pull request #2 from ahsandar/ahsandar-patch-1
62394d4 
gcs folder partition
HenryCaiHaiying pushed a commit that referenced this issue Jan 19, 2018
@achad4
Merge pull request #2 from sailthru/secor-testing
f694024 
More unit tests, ensure Avro schemas update, bug fix in ProtobufUtil
@alexivpx alexivpx mentioned this issue Feb 23, 2018
Closed
artem-garmash pushed a commit to artem-garmash/secor that referenced this issue Aug 8, 2018
@juhoautio
Merge pull request pinterest#2 from juho-autio/upgrade_s3_sdk
35bab1a 
Upgrade aws-java-sdk-s3 1.11.118 -> 1.11.119
jmbutter added a commit to jmbutter/secor that referenced this issue Aug 23, 2019
@jmbutter
[DP-313] Dont drop messages on rebalance (pinterest#2)
2bc2a1b 
* Add FormatConvertingUploadManager

* [DP-313] Dont drop messages on rebalance

* Address PR feedback

* Remove some println's
grouxsome referenced this issue in zenreach/secor-forkit Sep 10, 2019
@efeller
Merge pull request #2 from zenreach/efeller/secor_fixes
d017356 
Fixed a bug in remote url and path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@memelet @sclasen @pgarbacki