Flexible format and DailyOffsetPartition Parser #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcs folder partition
…nto flexible-partion-format
flexible timestamp format
| @@ -83,6 +102,30 @@ static boolean usingMinutely(SecorConfig config) { | |||
| return config.getBoolean("partitioner.granularity.minute", false); | |||
| } | |||
|
|
|||
| static String usingDateFormat(SecorConfig config) { | |||
There was a problem hiding this comment.
Should these methods instance method (vs. static)? Otherwise how did you make subclass override them?
|
|
||
| } | ||
|
|
||
| static boolean usingHourly(SecorConfig config) { |
There was a problem hiding this comment.
Should these be instance methods?
changed access modifier
|
i have updated the access modifier on the fields , there is no need to |
|
Thanks for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made Timestamped MessageParser to have flexible prefix and partition format for date, hour and minute, also added daily offset partitioning message parser to support following format to have partiotions backup up per day with hour and minute granularity
/mnt/secor_data/message_logs/backup/28248_12/Log/20161021/02/of fset=0/1_0_00000000000000025658.gz