Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexible format and DailyOffsetPartition Parser #275

Merged
merged 14 commits into from Oct 24, 2016

Conversation

@ahsandar
Copy link
Contributor

ahsandar commented Oct 21, 2016

Made Timestamped MessageParser to have flexible prefix and partition format for date, hour and minute, also added daily offset partitioning message parser to support following format to have partiotions backup up per day with hour and minute granularity
/mnt/secor_data/message_logs/backup/28248_12/Log/20161021/02/of fset=0/1_0_00000000000000025658.gz

Copy link
Contributor

HenryCaiHaiying left a comment

Overall looks fine. Minor comments

@@ -83,6 +102,30 @@ static boolean usingMinutely(SecorConfig config) {
return config.getBoolean("partitioner.granularity.minute", false);
}

static String usingDateFormat(SecorConfig config) {

This comment has been minimized.

Copy link
@HenryCaiHaiying

HenryCaiHaiying Oct 21, 2016

Contributor

Should these methods instance method (vs. static)? Otherwise how did you make subclass override them?


}

static boolean usingHourly(SecorConfig config) {

This comment has been minimized.

Copy link
@HenryCaiHaiying

HenryCaiHaiying Oct 21, 2016

Contributor

Should these be instance methods?

ahsandar added 2 commits Oct 22, 2016
@ahsandar

This comment has been minimized.

Copy link
Contributor Author

ahsandar commented Oct 22, 2016

i have updated the access modifier on the fields , there is no need to override these as they are config settings that are already defined and in essence shouldn't be overridden during execution once defined., please review

@HenryCaiHaiying HenryCaiHaiying merged commit 18a00c5 into pinterest:master Oct 24, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@HenryCaiHaiying

This comment has been minimized.

Copy link
Contributor

HenryCaiHaiying commented Oct 24, 2016

Thanks for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.