Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stan array syntax #1518

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Stan array syntax #1518

merged 3 commits into from
Jan 23, 2024

Conversation

MichaelClerx
Copy link
Member

@MichaelClerx MichaelClerx commented Jan 2, 2024

Closes #1516

Arrays int x[y] now need to be written array[y] int x

Note: Changes are only to a test and to a notebook, so no changelog entry required.

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (728a223) 100.00% compared to head (4156341) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1518   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           97        97           
  Lines         9577      9577           
=========================================
  Hits          9577      9577           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelClerx
Copy link
Member Author

Happy new year 🍾 @ben18785 !

Can you have a quick peek at this soon? The errors fixed here show up in other PRs too so would like to get this in soon :D

Copy link
Collaborator

@ben18785 ben18785 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- thanks @MichaelClerx

@ben18785 ben18785 merged commit 4f52588 into main Jan 23, 2024
13 checks passed
@ben18785 ben18785 deleted the 1516-stan-array-syntax branch January 23, 2024 15:37
@MichaelClerx
Copy link
Member Author

Thanks @I-Bouros ! Thanks @ben18785 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stan interface failing due to deprecated syntax
3 participants