Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spawn obstacles automatically #39

Merged
merged 3 commits into from
Jan 19, 2019
Merged

Conversation

pinussilvestrus
Copy link
Owner

@pinussilvestrus pinussilvestrus commented Jan 6, 2019

Closes #34

  • spawn obstacles automatically in the beginning
  • variable sizes
  • consider refactor the respawning

@codecov
Copy link

codecov bot commented Jan 6, 2019

Codecov Report

Merging #39 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #39     +/-   ##
=========================================
+ Coverage   98.42%   98.52%   +0.1%     
=========================================
  Files           6        6             
  Lines         190      204     +14     
=========================================
+ Hits          187      201     +14     
  Misses          3        3
Impacted Files Coverage Δ
lib/obstacle/obstacle.js 100% <100%> (ø) ⬆️
lib/canvas/canvas.js 100% <100%> (ø) ⬆️
lib/main/main.js 92.5% <100%> (+0.6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 092ae82...680a7ab. Read the comment docs.

@pinussilvestrus
Copy link
Owner Author

jan-06-2019 17-33-28

@pinussilvestrus
Copy link
Owner Author

One think we should consider is to replace the respawning of the obstacled with deleting them from the shapes array and just create a new one (delete the if clause). What do you think @Langleu ?

@pinussilvestrus pinussilvestrus changed the title WIP spawn obstacles automatically spawn obstacles automatically Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant