Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blacklist github.com/pkg/errors (maybe?) #48

Closed
Sean-Der opened this issue Sep 29, 2020 · 2 comments · Fixed by #49
Closed

Blacklist github.com/pkg/errors (maybe?) #48

Sean-Der opened this issue Sep 29, 2020 · 2 comments · Fixed by #49

Comments

@Sean-Der
Copy link
Member

It doesn't seem like we are getting much value from using this library. I vote drop it. It is used in pion/quic and pion/sctp

@scorpionknifes @enobufs Yay/Nay?
@scorpionknifes
Copy link
Member

I actually didn't catch that. Just double-checking, github.com/pkg/errors is used for compatibility? I don't see a problem blacklisting it.

@scorpionknifes scorpionknifes mentioned this issue Oct 3, 2020
Closed
@scorpionknifes
Copy link
Member

No idea where pion/quic uses github.com/pkg/errors. Thought it was github.com\lucas-clemente\quic-go but they also seem to also not use it?

@scorpionknifes scorpionknifes mentioned this issue Oct 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add 'github.com/pkg/errors' to blocked modules scorpionknifes/.goassets
2 participants
@Sean-Der @scorpionknifes