Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'github.com/pkg/errors' to blocked modules #49

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Add 'github.com/pkg/errors' to blocked modules #49

merged 1 commit into from
Oct 5, 2020

Conversation

scorpionknifes
Copy link
Member

Description

Added github.com/pkg/errors to blocked modules in .golangci.yml

Example lint warning

import of package `github.com/pkg/errors` is blocked because the module is in the blocked modules list. `errors` is a recommended module. (gomodguard)

Tested on pion/sctp

Reference issue

Fixes #48
pion/sctp#154

@scorpionknifes scorpionknifes changed the title Add github.com/pkg/errors to blocked modules Add 'github.com/pkg/errors' to blocked modules Oct 4, 2020
@scorpionknifes
Add 'github.com/pkg/errors' to blocked modules
035c665 
Don't use 'github.com/pkg/errors', use 'errors' instead
@Sean-Der Sean-Der merged commit 6ba5386 into pion:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sean-Der Sean-Der Sean-Der approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blacklist github.com/pkg/errors (maybe?)
2 participants
@scorpionknifes @Sean-Der